Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99977340
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,9 @@ class GeneralizedLinearRegression
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99460883
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -89,7 +89,7 @@ private[ml] class IterativelyRew
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99413491
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -89,7 +89,7 @@ private[ml] class IterativelyReweighte
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99407439
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,11 @@ class GeneralizedLinearRegression @S
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99408646
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +744,50 @@ class GeneralizedLinearRegressi
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99277921
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +744,48 @@ class GeneralizedLinearRe
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99276472
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +744,48 @@ class GeneralizedLinearR
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99276315
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,11 @@ class GeneralizedLinearRegress
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99273642
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,11 @@ class GeneralizedLinearRegres
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99269075
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,55 @@ class GeneralizedLinearRegressi
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99269006
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,55 @@ class GeneralizedLinearRe
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99268773
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,55 @@ class GeneralizedLinearRegressi
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98579939
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -86,13 +86,9 @@ private[ml] class IterativelyReweight
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98578921
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,54 @@ class GeneralizedLinearRegressi
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98493237
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -86,13 +86,11 @@ private[ml] class IterativelyR
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98488033
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,54 @@ class GeneralizedLinearR
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98486973
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -743,6 +743,54 @@ class GeneralizedLinearR
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98485335
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -86,13 +86,11 @@ private[ml] class Iteratively
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r98415092
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala
---
@@ -86,13 +86,11 @@ private[ml] class IterativelyReweigh
20 matches
Mail list logo
