Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17654#discussion_r235562839
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -935,7 +935,8 @@ class GeneralizedLinearRegressionMod
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17654#discussion_r235562982
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -444,31 +444,21 @@ class LinearRegressionModel private[ml] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17654#discussion_r235563050
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasTrainingSummary.scala ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundat
GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/17654
[SPARK-20351] [ML] Add trait hasTrainingSummary to replace the duplicate
code
## What changes were proposed in this pull request?
Add a trait HasTrainingSummary to avoid code duplicate rela
