[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-27 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113751399 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -89,6 +89,22 @@ object Cast { case _ =>

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-27 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113751468 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +181,14 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113609686 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +181,14 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113609438 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -89,6 +89,22 @@ object Cast { case _ =>

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113589853 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +165,22 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113589540 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +165,22 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113586201 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +165,22 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113585819 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +165,22 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r113585647 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,6 +165,22 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...

2017-04-26 Thread rednaxelafx
GitHub user rednaxelafx opened a pull request: https://github.com/apache/spark/pull/1 [SPARK-20482][SQL] Resolving Casts is too strict on having time zone set ## What changes were proposed in this pull request? Relax the requirement that a `TimeZoneAwareExpression` has