[GitHub] spark pull request #18016: [SPARK-20786][SQL]Improve ceil and floor handle t...

2017-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18016 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18016: [SPARK-20786][SQL]Improve ceil and floor handle t...

2017-05-21 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18016#discussion_r117650314 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -173,6 +173,14 @@ class MathFunctionsSuite extends QueryTest with

[GitHub] spark pull request #18016: [SPARK-20786][SQL]Improve ceil and floor handle t...

2017-05-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18016#discussion_r117512663 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -173,6 +173,14 @@ class MathFunctionsSuite extends QueryTest with

[GitHub] spark pull request #18016: [SPARK-20786][SQL]Improve ceil and floor handle t...

2017-05-18 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18016#discussion_r117397093 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -173,6 +173,14 @@ class MathFunctionsSuite extends QueryTest with

[GitHub] spark pull request #18016: [SPARK-20786][SQL]Improve ceil and floor handle t...

2017-05-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18016#discussion_r117320797 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -173,6 +173,14 @@ class MathFunctionsSuite extends QueryTest with