Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118834758
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +711,7 @@ nonReserved
| ADD
| OVER |
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118834583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -36,8 +36,17 @@ class UnresolvedException[TreeType <:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118833888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -36,8 +36,17 @@ class UnresolvedException[TreeType
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118833872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -592,7 +592,23 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118833830
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -592,7 +592,23 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118833821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -592,7 +592,23 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118833763
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +715,7 @@ nonReserved
| ADD
|
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118833766
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +711,7 @@ nonReserved
| ADD
|
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118396728
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,13 +472,17 @@ identifierComment
;
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118396605
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
---
@@ -49,7 +49,7 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118396491
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +715,7 @@ nonReserved
| ADD
| OVER |
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118310787
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -74,13 +74,13 @@ object TPCDSQueryBenchmark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118310768
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -74,13 +74,13 @@ object TPCDSQueryBenchmark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118310422
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,13 +472,17 @@ identifierComment
;
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118305063
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
---
@@ -49,7 +49,7 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118304894
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +715,7 @@ nonReserved
| ADD
|
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118134084
--- Diff: sql/core/src/test/resources/sql-tests/results/operators.sql.out
---
@@ -1,5 +1,5 @@
-- Automatically generated by SQLQueryTestSuite
---
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/18079
[SPARK-20841][SQL] Support column aliases for catalog tables
## What changes were proposed in this pull request?
This pr added parsing rules to support column aliases for catalog tables.
18 matches
Mail list logo
