[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125548280 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,29 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125548173 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,29 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125547523 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,29 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125546508 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,29 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125546465 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,29 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125546440 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,29 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125545875 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,26 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125468331 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,26 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125468128 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,26 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-04 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125421705 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -360,12 +368,10 @@ void forceSorterToSpill() throws

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-03 Thread manku-timma
Github user manku-timma commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125386319 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -360,12 +368,10 @@ void forceSorterToSpill() throws

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-02 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125204174 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,20 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-07-02 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125204165 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,20 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125106803 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,20 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125106509 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,20 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r125106486 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -335,4 +335,20 @@ package object config { "spark.")

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r124265367 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -123,6 +126,8 @@ this.inMemSorter = new

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r124239231 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java --- @@ -61,6 +65,9 @@ public

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-27 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r124214950 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java --- @@ -61,6 +65,9 @@ public

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-26 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r124182713 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java --- @@ -61,6 +65,9 @@ public

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r124041199 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java --- @@ -61,6 +65,9 @@ public

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r123932606 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -123,6 +126,8 @@ this.inMemSorter = new

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-25 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r123924134 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -123,6 +126,8 @@ this.inMemSorter = new

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-25 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r123923859 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -82,6 +82,9 @@ /** The buffer size to use when