[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128921212 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,17 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128921077 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -53,6 +65,18 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128919802 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -52,12 +55,22 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128919766 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128913707 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -52,12 +55,22 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128912524 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -71,10 +84,14 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128912116 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -162,5 +198,8 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128912086 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -52,12 +55,22 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128911351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128911210 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -36,7 +36,10 @@ import

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128911155 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-22 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128909042 --- Diff: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala --- @@ -52,12 +55,22 @@ class

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128908523 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128908519 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18714#discussion_r128908118 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -881,6 +881,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #18714: [SPARK-20236][SQL] hive style partition overwrite

2017-07-22 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18714 [SPARK-20236][SQL] hive style partition overwrite ## What changes were proposed in this pull request? When overwriting a partitioned table with dynamic partition columns, the behavior