[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135970632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -92,7 +92,24 @@ abstract class SparkPlan extends

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135970084 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -153,6 +139,14 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135967051 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -92,7 +92,24 @@ abstract class SparkPlan extends

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135966814 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135964775 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135949966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135950331 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135949262 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -153,6 +139,14 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135949500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135948798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135941833 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135870563 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135866202 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135851935 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -260,10 +230,10 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19080 [SPARK-21865][SQL] remove Partitioning.compatibleWith ## What changes were proposed in this pull request? `Partitioning.compatibleWith` is not well defined, ideally a `Partitioning`