[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19307 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140210945 --- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala --- @@ -128,9 +128,9 @@ class DoubleRDDFunctions(self: RDD[Double]) extends

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211316 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala --- @@ -625,6 +625,8 @@ class BasicSchedulerIntegrationSuite

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211172 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala --- @@ -83,11 +83,12 @@ class SparkSubmitUtilsSuite extends SparkFunSuite

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140210769 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala --- @@ -450,10 +450,9 @@ private[deploy] class Worker( }

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211761 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EnsureStatefulOpPartitioningSuite.scala --- @@ -20,6 +20,7 @@ package

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140210894 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -396,12 +396,12 @@ class DAGScheduler( /** Find ancestor

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140210563 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2826,33 +2826,33 @@ object WritableConverter { // them automatically.

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140210654 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -218,11 +218,13 @@ private[history] class

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211444 --- Diff: external/kafka-0-10-sql/pom.xml --- @@ -102,8 +102,19 @@ +

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211712 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala --- @@ -230,19 +230,16 @@ class DataFrameStatSuite extends QueryTest with

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140210528 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2826,33 +2826,33 @@ object WritableConverter { // them automatically.

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211059 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -501,8 +501,8 @@ private class JavaIterableWrapperSerializer

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140211607 --- Diff: repl/scala-2.12/src/main/scala/org/apache/spark/repl/SparkILoop.scala --- @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19307#discussion_r140212140 --- Diff: sql/hive-thriftserver/pom.xml --- @@ -63,6 +63,16 @@ ${hive.group} hive-beeline + --- End diff --

[GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...

2017-09-21 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/19307 [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE] Compile Spark REPL for Scala 2.12 + other 2.12 fixes ## What changes were proposed in this pull request? Enable Scala 2.12 REPL. Fix most