[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19719 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150402144 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,14 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150402135 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,14 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150368818 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -521,7 +521,20 @@ class HiveThr

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150368744 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150368620 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala --- @@ -55,6 +55,7 @@ private[hive] object SparkSQ

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150368111 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150366571 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150366512 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150366200 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -521,7 +521,20 @@ class HiveThr

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150364666 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150364544 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -66,6 +66,12 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150363309 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -521,7 +521,20 @@ class HiveT

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150362312 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -521,7 +521,20 @@ class HiveTh

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19719#discussion_r150358375 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -521,7 +521,20 @@ class HiveT

[GitHub] spark pull request #19719: [SPARK-22487][SQL][followup] still keep spark.sql...

2017-11-10 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19719 [SPARK-22487][SQL][followup] still keep spark.sql.hive.version ## What changes were proposed in this pull request? a followup of https://github.com/apache/spark/pull/19712 , adds back the