[GitHub] spark pull request #19801: [SPARK-22592][SQL] cleanup filter converting for ...

2017-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19801 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19801: [SPARK-22592][SQL] cleanup filter converting for ...

2017-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19801#discussion_r152880052 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -660,40 +626,68 @@ private[client] class Shim_v0_13 extends

[GitHub] spark pull request #19801: [SPARK-22592][SQL] cleanup filter converting for ...

2017-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19801#discussion_r152880027 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -643,9 +607,11 @@ private[client] class Shim_v0_13 extends

[GitHub] spark pull request #19801: [SPARK-22592][SQL] cleanup filter converting for ...

2017-11-23 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19801 [SPARK-22592][SQL] cleanup filter converting for hive ## What changes were proposed in this pull request? We have 2 different methods to convert filters for hive, regarding a config.