[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19803 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r153017609 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -147,6 +149,11 @@ trait CodegenSupport extends

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r153009697 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -147,6 +149,11 @@ trait CodegenSupport extends

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152938438 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -108,20 +108,22 @@ trait CodegenSupport extends

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152938354 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -108,20 +108,22 @@ trait CodegenSupport extends

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152899229 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -108,20 +108,22 @@ trait CodegenSupport extends

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152881282 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -60,20 +60,23 @@ case class

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152881786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -60,20 +60,23 @@ case class

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152883588 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -355,19 +355,12 @@ case class FileSourceScanExec(

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152883562 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -56,9 +56,7 @@ case class ProjectExec(projectList:

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152882655 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -355,19 +355,12 @@ case class FileSourceScanExec(

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152882876 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -56,9 +56,7 @@ case class ProjectExec(projectList:

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152881704 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -60,20 +60,23 @@ case class

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152849772 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -108,20 +108,22 @@ trait CodegenSupport extends

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19803#discussion_r152848960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -60,20 +60,23 @@ case class

[GitHub] spark pull request #19803: [SPARK-22596][SQL] set ctx.currentVars in Codegen...

2017-11-23 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19803 [SPARK-22596][SQL] set ctx.currentVars in CodegenSupport.consume ## What changes were proposed in this pull request? `ctx.currentVars` means the input variables for the current operator,