[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153763387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -788,11 +788,31 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153262121 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153140836 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153123637 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153120458 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153120160 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153099135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153098738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153095567 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153092301 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153092158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class CodegenContext {

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153087888 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153087865 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153087808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153087542 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -785,13 +785,36 @@ class

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/19821 [WIP][SPARK-22608][SQL] add new API to CodeGeneration.splitExpressions() ## What changes were proposed in this pull request? This PR adds a new API to ` CodeGenenerator.splitExpression`