Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20277
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162876178
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -33,18 +33,6 @@
private final ArrowVectorAccessor
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162862761
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -33,18 +33,6 @@
private final ArrowVectorAccessor
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162860736
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -127,8 +127,10 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162853774
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -55,164 +43,82 @@ public void close() {
if
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162844101
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -55,164 +43,82 @@ public void close() {
if
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162748352
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -55,164 +43,82 @@ public void close() {
if
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162747998
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -33,18 +33,6 @@
private final ArrowVectorAccessor
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162547306
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -50,7 +50,14 @@ private[sql] trait ColumnarBatchScan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162536698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -50,7 +50,14 @@ private[sql] trait ColumnarBatchScan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162536737
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -127,8 +127,14 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162534791
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -53,166 +41,83 @@ public int numNulls() {
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162531810
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -152,19 +198,11 @@ public final ColumnarRow getStruct(int
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162531441
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -53,166 +41,83 @@ public int numNulls() {
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162531459
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -53,166 +41,83 @@ public int numNulls() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r161957896
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -33,18 +33,6 @@
private final ArrowVectorAccessor
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r161816826
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -28,21 +28,14 @@
/**
* A column vector backed
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20277
[SPARK-23090][SQL] polish ColumnVector
## What changes were proposed in this pull request?
Several improvements:
* make ColumnVector an interface instead of abstract class
*
18 matches
Mail list logo
