[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163115407 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -116,7 +124,12 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163115184 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -46,6 +46,19 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163114625 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -46,6 +46,19 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-22 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r163113728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,46 @@ object ReorderJoin extends

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Respect Project nodes in Reord...

2018-01-21 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20345 [SPARK-23172][SQL] Respect Project nodes in ReorderJoin ## What changes were proposed in this pull request? The current `ReorderJoin` optimizer rule cannot flatten a pattern `Join -> Project ->