[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182624162 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -505,3 +505,59 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21037 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182298375 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +353,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182297896 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +353,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182298195 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +353,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182316985 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -18,6 +18,7 @@ package

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r182297625 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,23 @@ def array_contains(col, value): return

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181833370 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181827177 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181826436 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-16 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181825716 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181614224 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181613270 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181616266 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +106,26 @@ class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181613044 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181615751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181614388 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-12 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181283242 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-12 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181154371 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-12 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181151969 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181101544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181100763 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r180743190 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1002,6 +1002,57 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r180739909 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1002,6 +1002,57 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-11 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/21037 [SPARK-23919][SQL] Add array_position function ## What changes were proposed in this pull request? The PR adds the SQL function `array_position`. The behavior of the function is based on