[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21106 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r189840863 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala --- @@ -24,25 +24,30 @@ import

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r189818763 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala --- @@ -24,25 +24,30 @@ import

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r188914060 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala --- @@ -24,25 +24,29 @@ import

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r188913856 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -196,39 +197,33 @@ trait

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r19216 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala --- @@ -0,0 +1,57 @@

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r188872878 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala --- @@ -0,0 +1,57 @@

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r188872456 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala --- @@ -24,21 +24,27 @@ import

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r188871228 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -196,39 +197,35 @@ trait

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r188616153 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala --- @@ -0,0 +1,80 @@ +/*

[GitHub] spark pull request #21106: [SPARK-23711][SQL] Add fallback generator for Uns...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r187986602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala --- @@ -0,0 +1,80 @@ +/*