Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21321
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21321#discussion_r199091397
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21321#discussion_r198968646
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid:
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21321#discussion_r198964798
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21321#discussion_r195344259
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21321#discussion_r195156323
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid:
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/21321
[SPARK-24268][SQL] Use datatype.simpleString in error messages
## What changes were proposed in this pull request?
SPARK-22893 tried to unify error messages about dataTypes. Unfortunately,