Github user eric-maynard commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192820148
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user eric-maynard commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192819128
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192314729
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192314292
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192309419
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2696,16 +2687,6 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192274906
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ---
@@ -62,8 +62,9 @@ trait HashJoin {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192274753
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192274662
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192266906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -803,18 +803,60 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192266617
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ---
@@ -62,8 +62,9 @@ trait HashJoin {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192192426
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2675,15 +2675,6 @@ class SQLQuerySuite extends QueryTest with
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/21470
[SPARK-24443][SQL] comparison should accept structurally-equal types
## What changes were proposed in this pull request?
When comparing struct type values, it's a little hard to make the
12 matches
Mail list logo
