Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21501
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194626092
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194625679
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user dongjinleekr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194623958
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194606928
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194607278
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194606981
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194606418
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194346755
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala ---
@@ -65,6 +65,56 @@ class StopWordsRemoverSuite extends MLTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194346431
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala ---
@@ -65,6 +65,56 @@ class StopWordsRemoverSuite extends MLTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194343283
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user dongjinleekr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194342986
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194341627
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194298446
--- Diff: python/pyspark/ml/feature.py ---
@@ -2610,6 +2610,9 @@ def setParams(self, inputCol=None, outputCol=None,
stopWords=None, caseSensitive
Github user dongjinleekr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194296251
--- Diff: python/pyspark/ml/feature.py ---
@@ -2610,6 +2610,9 @@ def setParams(self, inputCol=None, outputCol=None,
stopWords=None, caseSensitive
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194293510
--- Diff: python/pyspark/ml/feature.py ---
@@ -2610,6 +2610,9 @@ def setParams(self, inputCol=None, outputCol=None,
stopWords=None, caseSensitive
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194244802
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194244784
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194244754
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user dongjinleekr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194222407
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user dongjinleekr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194222392
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194098947
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r194099298
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,28 @@ class StopWordsRemover @Since("1.5.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193963482
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193954052
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -95,8 +121,7 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193781216
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,27 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193777474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,31 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193779131
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,27 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193635361
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193604620
--- Diff: python/pyspark/ml/feature.py ---
@@ -2582,25 +2582,27 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193494337
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala ---
@@ -65,6 +67,56 @@ class StopWordsRemoverSuite extends MLTest
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193493040
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193493174
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193492568
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193492802
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193493663
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193493884
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21501#discussion_r193332595
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -84,7 +86,36 @@ class StopWordsRemover @Since("1.5.0")
GitHub user dongjinleekr opened a pull request:
https://github.com/apache/spark/pull/21501
[SPARK-15064][ML] Locale support in StopWordsRemover
## What changes were proposed in this pull request?
Add locale support for `StopWordsRemover`.
## How was this patch
39 matches
Mail list logo
