[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21921 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206946453 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -416,12 +405,12 @@ class AdvancedDataSourceV2 extends

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206946335 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -121,17 +121,6 @@ class DataSourceV2Suite extends

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206946259 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchReader.scala --- @@ -169,7 +170,7 @@ class

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206946076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala --- @@ -91,7 +90,7 @@ class

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206944875 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -416,12 +405,12 @@ class AdvancedDataSourceV2 extends

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206944348 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -121,17 +121,6 @@ class DataSourceV2Suite extends

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206944006 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchReader.scala --- @@ -169,7 +170,7 @@ class

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206943900 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala --- @@ -91,7 +90,7 @@ class

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206936701 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -456,57 +445,20 @@ class AdvancedInputPartition(start:

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206936422 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -416,12 +405,12 @@ class AdvancedDataSourceV2 extends

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206936202 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -121,17 +121,6 @@ class DataSourceV2Suite extends

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206935616 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchReader.scala --- @@ -169,7 +170,7 @@ class

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-08-01 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21921#discussion_r206935176 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala --- @@ -91,7 +90,7 @@ class

[GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...

2018-07-30 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/21921 [SPARK-24971][SQL] remove SupportsDeprecatedScanRow ## What changes were proposed in this pull request? This is a follow up of https://github.com/apache/spark/pull/21118 . In