[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22405 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217215209 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala --- @@ -167,13 +167,23

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217214888 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,18 @@

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217214721 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala --- @@ -167,13

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217214065 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,18 @@

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217213999 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,18 @@

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217189938 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17 @@

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217189066 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17 @@

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217177996 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217178781 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22405#discussion_r217170079 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala --- @@ -254,3 +251,17 @@

[GitHub] spark pull request #22405: [SPARK-25295][K8S]Fix executor names collision

2018-09-12 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/22405 [SPARK-25295][K8S]Fix executor names collision ## What changes were proposed in this pull request? Fixes the collision issue with spak executor names in client mode. Also fixes the issue