[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220218715 --- Diff: python/pyspark/sql/column.py --- @@ -54,6 +54,22 @@ def _to_java_column(col): return jcol +def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220218332 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread annamolchanova
Github user annamolchanova commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220169775 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220122281 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread annamolchanova
Github user annamolchanova commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220089447 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r219902083 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-24 Thread annamolchanova
Github user annamolchanova commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r219898548 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-24 Thread annamolchanova
Github user annamolchanova commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r219898059 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r219811169 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r219812531 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-24 Thread annamolchanova
GitHub user annamolchanova opened a pull request: https://github.com/apache/spark/pull/22533 [SPARK-18818][PYTHON] Add 'ascending' parameter to Window.orderBy() ## What changes were proposed in this pull request? Pass `ascending` parameter to Window's orderBy() function the