viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075559200
Do we need to create JIRA ticket for this? @hiboyang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075558029
maybe cc @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578326225
##
go.mod:
##
@@ -49,10 +49,10 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/zeebo/xxh3 v1.0.2 // indirect
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578325614
##
internal/generated/expressions.pb.go:
##
@@ -211,6 +211,7 @@ type Expression struct {
// *Expression_UpdateFields_
//
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1578324700
##
client/sql/dataframe.go:
##
@@ -23,7 +23,7 @@ import (
"github.com/apache/arrow/go/v12/arrow"
"github.com/apache/arrow/go/v12/arrow/array"
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2075513386
Yeah, Go module name normally put `v2`/`v3`/etc in the end to indicate major
version bump, like `module example.com/mymodule/v2`, see example in the end of
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073619182
Got it. I didn't know the actual meaning of `v34` so I thought that you had
v1, v2, ...v34 before.
I am also not sure why the version number is embedded into the Go module
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073588176
> > Use v1 for this Spark Connect Go Client library, instead of previously
using v34.
>
> For Spart K8s operator, we begin with 0.1.0 as the first release version
as
hiboyang commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1576977935
##
go.mod:
##
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module
hiboyang commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073580127
> Does this Spark connect go library have any previous release yet?
No release previously. For GoLang repo, people can just import the repo
directly. Thus such "releasing" is
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2071485404
> Use v1 for this Spark Connect Go Client library, instead of previously
using v34.
For Spart K8s operator, we begin with 0.1.0 as the first release version as
discussion in
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1575692381
##
go.mod:
##
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module
viirya commented on code in PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#discussion_r1575690071
##
go.mod:
##
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module
viirya commented on PR #19:
URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2071185132
Does this Spark connect go library have any previous release yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hiboyang opened a new pull request, #19:
URL: https://github.com/apache/spark-connect-go/pull/19
### What changes were proposed in this pull request?
Use v1 for this Spark Connect Go Client library, instead of previously using
v34.
### Why are the changes needed?
There
15 matches
Mail list logo
