nikolamand-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1561110745
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
cloud-fan closed pull request #45978: [SPARK-47410][SQL] Refactor UTF8String
and CollationFactory
URL: https://github.com/apache/spark/pull/45978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan commented on PR #45978:
URL: https://github.com/apache/spark/pull/45978#issuecomment-2049808333
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uros-db commented on PR #45978:
URL: https://github.com/apache/spark/pull/45978#issuecomment-2049806525
@cloud-fan all checks look good, ready to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
miland-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1561064293
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1561064861
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationStringExpressions.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1561059364
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1561054469
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1561054469
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
cloud-fan commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560959880
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560772584
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dbatomic commented on PR #45978:
URL: https://github.com/apache/spark/pull/45978#issuecomment-2049342650
Just wanted to thank you for doing this. IMO, things are much cleaner than
they used to be.
Also, @mihailom-db , @nikolamand-db , @stefankandic and @stevomitric as FYI.
--
This is
dbatomic commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560761873
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dbatomic commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560754473
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -93,9 +101,12 @@ public Collation(
this.hashFunction =
uros-db commented on PR #45978:
URL: https://github.com/apache/spark/pull/45978#issuecomment-2049008530
updated PR description, stand by for some more small changes before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560453598
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560454235
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cloud-fan commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560452406
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation
cloud-fan commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1560451327
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -172,19 +183,31 @@ public Collation(
}
/**
- * Auxiliary
HyukjinKwon commented on PR #45978:
URL: https://github.com/apache/spark/pull/45978#issuecomment-2048651969
Can you please fill the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1559445525
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1559441689
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1559441689
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
uros-db commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1559438477
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dbatomic commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1559428506
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dbatomic commented on code in PR #45978:
URL: https://github.com/apache/spark/pull/45978#discussion_r1559427040
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
26 matches
Mail list logo
