dongjoon-hyun commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2046598213
Thank you, @pan3793 and all.
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun closed pull request #45838: [SPARK-47706][BUILD] Bump json4s 4.0.7
URL: https://github.com/apache/spark/pull/45838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pan3793 commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2046557968
@LuciferYang @dongjoon-hyun The failed test is known flaky case, I
re-triggered CI, thanks for your approval and help with Mima
--
This is an automated message from the Apache Git
dongjoon-hyun commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2046536383
Could you re-trigger the failed test pipeline, @pan3793 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
pan3793 commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2046420830
rebased on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1557856537
##
sql/api/pom.xml:
##
@@ -56,13 +56,6 @@
org.json4s
json4s-jackson_${scala.binary.version}
-3.7.0-M11
Review
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556905110
##
sql/api/pom.xml:
##
@@ -56,13 +56,6 @@
org.json4s
json4s-jackson_${scala.binary.version}
-3.7.0-M11
Review Comment:
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556899643
##
sql/api/pom.xml:
##
@@ -56,13 +56,6 @@
org.json4s
json4s-jackson_${scala.binary.version}
-3.7.0-M11
Review
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556900847
##
sql/api/pom.xml:
##
@@ -56,13 +56,6 @@
org.json4s
json4s-jackson_${scala.binary.version}
-3.7.0-M11
Review Comment:
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556899643
##
sql/api/pom.xml:
##
@@ -56,13 +56,6 @@
org.json4s
json4s-jackson_${scala.binary.version}
-3.7.0-M11
Review
dongjoon-hyun commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2044149193
Thank you for rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
pan3793 commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2044102847
@dongjoon-hyun @cloud-fan @gengliangwang @LuciferYang I updated
MimaExcludes, now it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message,
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556835313
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556834466
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,11 @@ object MimaExcludes {
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556833527
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,11 @@ object MimaExcludes {
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556656706
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
dongjoon-hyun commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2043927068
To @pan3793 , for MIMA issue, I made the following PR to fix it.
- #45938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556539422
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556539422
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556151836
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1556151836
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1555230740
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
pan3793 commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2041867141
@cloud-fan seems json4s does not have release note. the API binary
incompatible does not affect JSON serialize/deserialize, the case of parsing
event log generated by the previous Spark
cloud-fan commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2041836659
does json4s release notes mention anything about backward compatibility? We
have persistent event logs in JSON format that may need to be consumed by new
version of Spark history
gengliangwang commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2041235111
Since there are many connectors/libraries that depend on Spark, I am +0 on
this one.
--
This is an automated message from the Apache Git Service.
To respond to the message,
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1549972129
##
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufFunctionsSuite.scala:
##
@@ -22,7 +22,6 @@ import java.time.Duration
import
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1549948290
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1549942965
##
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufFunctionsSuite.scala:
##
@@ -22,7 +22,6 @@ import java.time.Duration
import
dongjoon-hyun commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1549937536
##
project/MimaExcludes.scala:
##
@@ -90,7 +90,21 @@ object MimaExcludes {
pan3793 commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2034852723
@LuciferYang `MimaExcludes` is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pan3793 commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2034104674
@LuciferYang json4s classes leaked to public(maybe? at least in the Mima
audit list) API, and json4s 4.x changed those classes, this requires the Spark
community to evaluate if we should
LuciferYang commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2034076896
I get errors when I manually run the mima check. Could you please update the
`MimaExcludes`?
```
[error] spark-sql-api: Failed binary compatibility check against
LuciferYang commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2034039323
Previously, there were two unsuccessful upgrade attempts:
- https://github.com/apache/spark/pull/32636
- https://github.com/apache/spark/pull/33630
cc
pan3793 commented on code in PR #45838:
URL: https://github.com/apache/spark/pull/45838#discussion_r1549070164
##
sql/api/pom.xml:
##
@@ -56,13 +56,6 @@
org.json4s
json4s-jackson_${scala.binary.version}
-3.7.0-M11
Review Comment:
pan3793 opened a new pull request, #45838:
URL: https://github.com/apache/spark/pull/45838
### What changes were proposed in this pull request?
Bump json4s from 3.7.0-M11 to 4.0.7
### Why are the changes needed?
4.0.7 is the latest stable version of json4s.
35 matches
Mail list logo
