Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-28 Thread via GitHub
dongjoon-hyun commented on PR #46149: URL: https://github.com/apache/spark/pull/46149#issuecomment-2081755480 I added you (Xi Chen) to Apache Spark contributor group and assigned SPARK-47730 to you. Welcome to the Apache Spark community, @jshmchenxi ! -- This is an automated message

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-28 Thread via GitHub
dongjoon-hyun closed pull request #46149: [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels URL: https://github.com/apache/spark/pull/46149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-27 Thread via GitHub
jshmchenxi commented on code in PR #46149: URL: https://github.com/apache/spark/pull/46149#discussion_r1581765866 ## resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala: ## @@ -35,7 +35,9 @@ import

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-27 Thread via GitHub
jshmchenxi commented on PR #46149: URL: https://github.com/apache/spark/pull/46149#issuecomment-2080412508 It's been a busy week, sorry for the delay. I'll address your comments today, thanks! @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on PR #46149: URL: https://github.com/apache/spark/pull/46149#issuecomment-2071446978 Gentle ping, @jshmchenxi . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-21 Thread via GitHub
dongjoon-hyun commented on code in PR #46149: URL: https://github.com/apache/spark/pull/46149#discussion_r1574057309 ## resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala: ## @@ -589,7 +589,8 @@ class

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-21 Thread via GitHub
dongjoon-hyun commented on code in PR #46149: URL: https://github.com/apache/spark/pull/46149#discussion_r1574056783 ## resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala: ## @@ -102,13 +102,15 @@

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-21 Thread via GitHub
dongjoon-hyun commented on code in PR #46149: URL: https://github.com/apache/spark/pull/46149#discussion_r1574056485 ## resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala: ## @@ -35,7 +35,9 @@ import

Re: [PR] [SPARK-47730][K8S] Support `APP_ID` and `EXECUTOR_ID` placeholders in labels [spark]

2024-04-21 Thread via GitHub
dongjoon-hyun commented on code in PR #46149: URL: https://github.com/apache/spark/pull/46149#discussion_r1574055887 ## resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala: ## @@ -35,7 +35,9 @@ import

Re: [PR] [SPARK-47730][K8S] Support APP_ID and EXECUTOR_ID placeholders in labels [spark]

2024-04-21 Thread via GitHub
jshmchenxi commented on PR #46149: URL: https://github.com/apache/spark/pull/46149#issuecomment-2068041487 cc @dongjoon-hyun This is a similar feature as #35704 and #42600. Please take a look, thanks! -- This is an automated message from the Apache Git Service. To respond to the

[PR] [SPARK-47730][K8S] Support APP_ID and EXECUTOR_ID placeholders in labels [spark]

2024-04-21 Thread via GitHub
jshmchenxi opened a new pull request, #46149: URL: https://github.com/apache/spark/pull/46149 Currently, only the pod annotations supports `APP_ID` and `EXECUTOR_ID` placeholders. This commit aims to add the same function to pod labels. The use case is to support using customized