Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun closed pull request #45895: [SPARK-47739][SQL] Register logical avro type URL: https://github.com/apache/spark/pull/45895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

milastdbx commented on PR #45895: URL: https://github.com/apache/spark/pull/45895#issuecomment-2058566838 Sorry for the wrong ping. I didn't check whether push succeeded. It turns out it failed because there was a commit inbetween, and i didn't notice. -- This is an automated

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on PR #45895: URL: https://github.com/apache/spark/pull/45895#issuecomment-2058009387 To @milastdbx , why did you request a review to me when you didn't address my comment? ![Screenshot 2024-04-15 at 17 03

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1564350531 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeInitSuite.scala: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1564350217 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeInitSuite.scala: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1564349334 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeInitSuite.scala: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

milastdbx commented on PR #45895: URL: https://github.com/apache/spark/pull/45895#issuecomment-2049561339 @dongjoon-hyun I've isolated test in separate suite to address issue you found. This does not eliminate it if multiple suites are run however. Please take another look and i'd

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

milastdbx commented on PR #45895: URL: https://github.com/apache/spark/pull/45895#issuecomment-2042987166 @dongjoon-hyun thanks for the review. You are absolutely right. Your tests are passing because you are running them in batch, and this regression only really happens if you call don't

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1554650108 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeSuite.scala: ## @@ -82,6 +82,35 @@ abstract class AvroLogicalTypeSuite extends

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1554649652 ## connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala: ## @@ -43,6 +43,8 @@ import org.apache.spark.util.SerializableConfiguration

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1554649464 ## connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroUtils.scala: ## @@ -43,6 +43,9 @@ import org.apache.spark.sql.types._ import

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1554649268 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeSuite.scala: ## @@ -82,6 +82,35 @@ abstract class AvroLogicalTypeSuite extends

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1554648407 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeSuite.scala: ## @@ -82,6 +82,35 @@ abstract class AvroLogicalTypeSuite extends

Re: [PR] [SPARK-47739][SQL] Register logical avro type [spark]

dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1554648407 ## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeSuite.scala: ## @@ -82,6 +82,35 @@ abstract class AvroLogicalTypeSuite extends