Re: [PR] [SPARK-47907] Put bang under a config [spark]

gengliangwang commented on PR #46138: URL: https://github.com/apache/spark/pull/46138#issuecomment-2070929813 Thanks, merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47907] Put bang under a config [spark]

gengliangwang commented on PR #46138: URL: https://github.com/apache/spark/pull/46138#issuecomment-2070490445 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47907] Put bang under a config [spark]

gengliangwang commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1575178238 ## sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql: ## @@ -82,3 +82,8 @@ select 2.0 not between '1.0' and '3.0'; select 'b' not between 'a'

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1575175337 ## sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql: ## @@ -82,3 +82,8 @@ select 2.0 not between '1.0' and '3.0'; select 'b' not between 'a' and

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1575173778 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -365,6 +367,8 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-47907] Put bang under a config [spark]

gengliangwang commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1575117121 ## sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql: ## @@ -82,3 +82,8 @@ select 2.0 not between '1.0' and '3.0'; select 'b' not between 'a'

Re: [PR] [SPARK-47907] Put bang under a config [spark]

gengliangwang commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1575115453 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -365,6 +367,8 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574101454 ## common/utils/src/main/resources/error/error-conditions.json: ## @@ -3798,6 +3798,21 @@ ], "sqlState" : "22003" }, + "SYNTAX_DISCONTINUED" : { +

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574095617 ## common/utils/src/main/resources/error/error-conditions.json: ## @@ -3798,6 +3798,21 @@ ], "sqlState" : "22003" }, + "SYNTAX_DISCONTINUED" : { +

Re: [PR] [SPARK-47907] Put bang under a config [spark]

cloud-fan commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574094424 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -365,6 +367,8 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574088137 ## sql/core/src/test/resources/sql-tests/analyzer-results/predicate-functions.sql.out: ## @@ -450,3 +450,18 @@ Project [NOT between(to_timestamp(2022-12-26 00:00:01,

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574085978 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -365,6 +367,8 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-47907] Put bang under a config [spark]

cloud-fan commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574084085 ## sql/core/src/test/resources/sql-tests/analyzer-results/predicate-functions.sql.out: ## @@ -450,3 +450,18 @@ Project [NOT between(to_timestamp(2022-12-26 00:00:01,

Re: [PR] [SPARK-47907] Put bang under a config [spark]

cloud-fan commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r1574084230 ## common/utils/src/main/resources/error/error-conditions.json: ## @@ -3798,6 +3798,21 @@ ], "sqlState" : "22003" }, + "SYNTAX_DISCONTINUED" : { +

Re: [PR] [SPARK-47907] Put bang under a config [spark]

cloud-fan commented on code in PR #46138: URL: https://github.com/apache/spark/pull/46138#discussion_r157408 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -365,6 +367,8 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-47907] Put bang under a config [spark]

srielau commented on PR #46138: URL: https://github.com/apache/spark/pull/46138#issuecomment-2067511478 @cloud-fan @gengliangwang This is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above