Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-22 Thread via GitHub
yaooqinn commented on PR #46150: URL: https://github.com/apache/spark/pull/46150#issuecomment-2071269848 Hi @dongjoon-hyun, tests of HiveVersionsSuite might cover hive dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on PR #46150: URL: https://github.com/apache/spark/pull/46150#issuecomment-2070395033 Anyway, +1 for this change too because this is `sql/core` module instead of `sql/hive`. I believe we have another place to check this test coverage in `sql/hive` module.

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on PR #46150: URL: https://github.com/apache/spark/pull/46150#issuecomment-2070302471 Does this PR aim to mitigate this? - https://github.com/apache/spark/pull/45372#discussion_r1574143381 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-22 Thread via GitHub
LuciferYang commented on PR #46150: URL: https://github.com/apache/spark/pull/46150#issuecomment-2069057088 Merged into master. Thanks @pan3793 and @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-22 Thread via GitHub
LuciferYang closed pull request #46150: [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" URL: https://github.com/apache/spark/pull/46150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-22 Thread via GitHub
pan3793 commented on PR #46150: URL: https://github.com/apache/spark/pull/46150#issuecomment-2068917863 cc @yaooqinn @AngersZh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-21 Thread via GitHub
pan3793 commented on PR #46150: URL: https://github.com/apache/spark/pull/46150#issuecomment-2068478468 cc @dongjoon-hyun @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-21 Thread via GitHub
pan3793 commented on code in PR #46150: URL: https://github.com/apache/spark/pull/46150#discussion_r1573890525 ## sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala: ## @@ -3748,22 +3748,21 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with

[PR] [SPARK-47928][SQL][TEST] Speed up test "Add jar support Ivy URI in SQL" [spark]

2024-04-21 Thread via GitHub
pan3793 opened a new pull request, #46150: URL: https://github.com/apache/spark/pull/46150 ### What changes were proposed in this pull request? `SQLQuerySuite`/"SPARK-33084: Add jar support Ivy URI in SQL" uses Hive deps to test `ADD JAR` which pulls tons of transitive deps,