Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-23 Thread via GitHub
yaooqinn commented on PR #46153: URL: https://github.com/apache/spark/pull/46153#issuecomment-2071558003 Thank you @LuciferYang and all. Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-23 Thread via GitHub
yaooqinn closed pull request #46153: [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive URL: https://github.com/apache/spark/pull/46153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
yaooqinn commented on code in PR #46153: URL: https://github.com/apache/spark/pull/46153#discussion_r1574419574 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java: ## @@ -85,15 +73,6 @@ public String getDelegationToken() {

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
cloud-fan commented on code in PR #46153: URL: https://github.com/apache/spark/pull/46153#discussion_r1574399090 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java: ## @@ -85,15 +73,6 @@ public String getDelegationToken() {

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
yaooqinn commented on code in PR #46153: URL: https://github.com/apache/spark/pull/46153#discussion_r1574355707 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java: ## @@ -85,15 +73,6 @@ public String getDelegationToken() {

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
LuciferYang commented on PR #46153: URL: https://github.com/apache/spark/pull/46153#issuecomment-2068811573 also cc @wangyum FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
yaooqinn commented on code in PR #46153: URL: https://github.com/apache/spark/pull/46153#discussion_r1574354918 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java: ## @@ -85,15 +73,6 @@ public String getDelegationToken() {

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on PR #46153: URL: https://github.com/apache/spark/pull/46153#issuecomment-2068722840 cc @sunchao, @LuciferYang , @pan3793 , too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on code in PR #46153: URL: https://github.com/apache/spark/pull/46153#discussion_r1574288193 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java: ## @@ -85,15 +73,6 @@ public String getDelegationToken()

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
cloud-fan commented on code in PR #46153: URL: https://github.com/apache/spark/pull/46153#discussion_r1574288295 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java: ## @@ -85,15 +73,6 @@ public String getDelegationToken() {

Re: [PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-22 Thread via GitHub
yaooqinn commented on PR #46153: URL: https://github.com/apache/spark/pull/46153#issuecomment-2068702755 cc @dongjoon-hyun @cloud-fan thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [SPARK-47931][SQL] Remove unused and leaked threadlocal/session sessionHive [spark]

2024-04-21 Thread via GitHub
yaooqinn opened a new pull request, #46153: URL: https://github.com/apache/spark/pull/46153 ### What changes were proposed in this pull request? This `sessionHive` is never used and properly closed ### Why are the changes needed? A thread local