Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-22 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1610072254 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala: ## @@ -103,7 +103,8 @@ case class ScalarUserDefinedFunction

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-21 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1608851090 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/UserDefinedFunctionE2ETestSuite.scala: ## @@ -346,4 +347,42 @@ class

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-21 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1608832100 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala: ## @@ -103,7 +103,8 @@ case class

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-21 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1608831659 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-21 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1608830698 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-15 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596852526 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-15 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1601524741 ## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ## @@ -379,6 +380,15 @@ message ScalarScalaUDF { bool nullable = 4; } +message

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-15 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1601524509 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala: ## @@ -205,6 +205,91 @@ object ScalarUserDefinedFunction {

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-10 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596852526 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-10 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596852526 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-10 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596852526 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-10 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596852526 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-10 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596845911 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-10 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1596845911 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594544696 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594250192 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594229607 ## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ## @@ -379,6 +380,15 @@ message ScalarScalaUDF { bool nullable = 4; } +message

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594227631 ## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ## @@ -379,6 +380,15 @@ message ScalarScalaUDF { bool nullable = 4; } +message

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594223201 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
xupefei commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594216679 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594210664 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala: ## @@ -205,6 +205,91 @@ object ScalarUserDefinedFunction

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594209214 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-05-08 Thread via GitHub
hvanhovell commented on code in PR #46245: URL: https://github.com/apache/spark/pull/46245#discussion_r1594208101 ## sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala: ## @@ -49,6 +49,7 @@ import

[PR] [SPARK-48008][WIP] Support UDAFs in Spark Connect [spark]

2024-04-26 Thread via GitHub
xupefei opened a new pull request, #46245: URL: https://github.com/apache/spark/pull/46245 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How