Re: [PR] [SPARK-47413][SQL] [WIP - DONT REVIEW] - add support to substr/left/right for collations [spark]

2024-04-07 Thread via GitHub
uros-db commented on code in PR #45738: URL: https://github.com/apache/spark/pull/45738#discussion_r1555227674 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest

Re: [PR] [SPARK-47413][SQL] [WIP - DONT REVIEW] - add support to substr/left/right for collations [spark]

2024-04-07 Thread via GitHub
GideonPotok commented on code in PR #45738: URL: https://github.com/apache/spark/pull/45738#discussion_r1555192610 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends

Re: [PR] [SPARK-47413][SQL] [WIP - DONT REVIEW] - add support to substr/left/right for collations [spark]

2024-04-07 Thread via GitHub
uros-db commented on code in PR #45738: URL: https://github.com/apache/spark/pull/45738#discussion_r1554838890 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest