panbingkun commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1590471939
##
connector/profiler/src/main/scala/org/apache/spark/executor/profiler/ExecutorProfilerPlugin.scala:
##
@@ -23,7 +23,8 @@ import scala.util.Random
import
dongjoon-hyun commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1589845846
##
connector/profiler/src/main/scala/org/apache/spark/executor/profiler/ExecutorJVMProfiler.scala:
##
@@ -25,7 +25,8 @@ import org.apache.hadoop.fs.{FileSystem,
dongjoon-hyun commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1589845864
##
connector/profiler/src/main/scala/org/apache/spark/executor/profiler/ExecutorProfilerPlugin.scala:
##
@@ -23,7 +23,8 @@ import scala.util.Random
import
gengliangwang closed pull request #46022: [SPARK-47594] Connector module:
Migrate logInfo with variables to structured logging framework
URL: https://github.com/apache/spark/pull/46022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gengliangwang commented on PR #46022:
URL: https://github.com/apache/spark/pull/46022#issuecomment-2059867235
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
panbingkun commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r150002
##
connector/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala:
##
@@ -325,7 +327,8 @@ private[spark] class
panbingkun commented on PR #46022:
URL: https://github.com/apache/spark/pull/46022#issuecomment-2058093392
> @panbingkun Thanks for the works. LGTM except for some minor comments.
Updated. Thank you for your review!
--
This is an automated message from the Apache Git Service.
To
gengliangwang commented on PR #46022:
URL: https://github.com/apache/spark/pull/46022#issuecomment-2057848786
@panbingkun Thanks for the works. LGTM except for some minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566462197
##
connector/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala:
##
@@ -325,7 +327,8 @@ private[spark] class
gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566459384
##
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/consumer/KafkaDataConsumer.scala:
##
@@ -391,10 +392,12 @@ private[kafka010] class
gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566459174
##
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/consumer/KafkaDataConsumer.scala:
##
@@ -391,10 +392,12 @@ private[kafka010] class
gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566451471
##
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamingQueryCache.scala:
##
@@ -70,7 +70,9 @@ private[connect]
gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566449680
##
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectServer.scala:
##
@@ -38,8 +39,8 @@ object SparkConnectServer extends
gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566448773
##
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectExecutionManager.scala:
##
@@ -95,7 +95,7 @@ private[connect] class
panbingkun commented on PR #46022:
URL: https://github.com/apache/spark/pull/46022#issuecomment-2056317368
cc @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
15 matches
Mail list logo