Github user jongyoul commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71150639
/cc @tnachen @pwendell This PR is about @pwendell 's todo. Review this,
please.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71150832
[Test build #25997 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25997/consoleFull)
for PR 4170 at commit
[`71703c8`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71151118
[Test build #25998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25998/consoleFull)
for PR 4170 at commit
[`f655eee`](https://githu
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4032#issuecomment-71151138
LGTM. Merging this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4032#issuecomment-71151116
LGTM. Merging this. Thanks!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4104#issuecomment-71151363
LGTM. Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/4032#issuecomment-71151653
Thanks for your reviewing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3720#issuecomment-71151864
Thanks! I've merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4134#issuecomment-71152064
I'm pretty busy with other work at the moment, so it'll be a little while
before I can actually review this, but I'd be glad to let Jenkins test it to
see whether it un
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4170#discussion_r23433897
--- Diff: docs/configuration.md ---
@@ -341,6 +341,13 @@ Apart from these, the following properties are also
available, and may be useful
`spark.meso
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4170#discussion_r23433902
--- Diff: docs/running-on-mesos.md ---
@@ -226,6 +226,13 @@ See the [configuration page](configuration.html) for
information on Spark config
The fina
Github user JoshRosen closed the pull request at:
https://github.com/apache/spark/pull/4066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4066#issuecomment-71153008
@mccheah Thanks for picking this up. I'm going to close my PR and continue
discussion on yours.
---
If your project is set up for it, you can reply to this email and
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23433950
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23433968
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user jongyoul commented on a diff in the pull request:
https://github.com/apache/spark/pull/4170#discussion_r23433986
--- Diff: docs/configuration.md ---
@@ -341,6 +341,13 @@ Apart from these, the following properties are also
available, and may be useful
`spark.mes
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23433989
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23433984
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23433999
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23434003
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23434036
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4158#issuecomment-71153535
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4158#issuecomment-71153531
[Test build #25996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25996/consoleFull)
for PR 4158 at commit
[`a7b6989`](https://gith
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4155#issuecomment-71153542
I'd be happy to help debug the test hang issue. To confirm, though, have
you tested this with your original bug reproduction from JIRA to see whether it
resolves that
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23434086
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache So
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/4082#issuecomment-71153562
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71153592
[Test build #25999 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25999/consoleFull)
for PR 4170 at commit
[`9054535`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4082#issuecomment-71153614
[Test build #26000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26000/consoleFull)
for PR 4082 at commit
[`979dfe1`](https://githu
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/3988#issuecomment-71153597
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23434145
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache So
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71153844
[Test build #25997 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25997/consoleFull)
for PR 4170 at commit
[`71703c8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71153847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71153845
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71153842
[Test build #25998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25998/consoleFull)
for PR 4170 at commit
[`f655eee`](https://gith
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4155#discussion_r23434185
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache So
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3988#issuecomment-71153885
[Test build #26001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26001/consoleFull)
for PR 3988 at commit
[`e24e01b`](https://githu
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/4171
[SPARK-5379][Streaming] Add awaitTerminationOrTimeout
Added `awaitTerminationOrTimeout` to return if the waiting time elapsed:
* `true` if it's stopped.
* `false` if the waiting time elapsed
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4171#issuecomment-71154979
cc @tdas, @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user mccheah commented on the pull request:
https://github.com/apache/spark/pull/4155#issuecomment-71155039
Lots of comments to address, thanks for the detailed feedback @JoshRosen!
One hanging cause is that the actor can be stopped multiple times in some of
the YARN tests, so
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71155131
[Test build #26003 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26003/consoleFull)
for PR 4170 at commit
[`a28b666`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4171#issuecomment-71155123
[Test build #26002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26002/consoleFull)
for PR 4171 at commit
[`cdc820b`](https://githu
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4136#issuecomment-71155272
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4136#issuecomment-71155268
This is a spurious test failure due to a build break in SQL. Let's retest:
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-71155467
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/4055#issuecomment-71155435
I can't figure out why there will be 2 task sets when retry
MapStage1..Could you add a real world case which may reproduce this issue?
---
If your project is set u
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4136#issuecomment-71155446
[Test build #26004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26004/consoleFull)
for PR 4136 at commit
[`0a2f32b`](https://githu
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3794#discussion_r23434730
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -495,6 +495,19 @@ class DAGScheduler(
assert(partitions.size > 0
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r23434739
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -540,6 +540,52 @@ class DAGSchedulerSuite extends
TestKit(ActorSyst
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3794#issuecomment-71155707
This approach looks good to me, so feel free to bring this up to date with
master.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-71155784
[Test build #26005 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26005/consoleFull)
for PR 3564 at commit
[`f697a55`](https://githu
Github user mccheah commented on the pull request:
https://github.com/apache/spark/pull/4155#issuecomment-71155895
Pushed to try to make Jenkins pass. If Jenkins passes I'll handle the
comments so far.
---
If your project is set up for it, you can reply to this email and have your
re
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4155#issuecomment-71156155
[Test build #26006 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26006/consoleFull)
for PR 4155 at commit
[`c334255`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-71157110
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
GitHub user jongyoul opened a pull request:
https://github.com/apache/spark/pull/4172
[SPARK-5058] Part 2. Typos and broken URL
- Also fixed java link
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/spark SPARK-FIXDOC
Al
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3564#issuecomment-71157106
[Test build #26005 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26005/consoleFull)
for PR 3564 at commit
[`f697a55`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4172#issuecomment-71157186
[Test build #26007 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26007/consoleFull)
for PR 4172 at commit
[`6be03e5`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71157354
[Test build #25999 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25999/consoleFull)
for PR 4170 at commit
[`9054535`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4170#issuecomment-71157359
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3988#issuecomment-71158345
[Test build #26001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26001/consoleFull)
for PR 3988 at commit
[`e24e01b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3988#issuecomment-71158351
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4082#issuecomment-71158426
[Test build #26000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26000/consoleFull)
for PR 4082 at commit
[`979dfe1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4082#issuecomment-71158431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user jongyoul commented on the pull request:
https://github.com/apache/spark/pull/4172#issuecomment-71158869
/cc @tdas This PR is a second part of
[SPARK-5058](https://issues.apache.org/jira/browse/SPARK-5058) which you
already reviewed and resolved.
---
If your project is se
301 - 366 of 366 matches
Mail list logo
