[GitHub] spark pull request: [SPARK-11379][SQL] ExpressionEncoder can't han...

2015-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152143301 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152143323 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11400][SQL] BroadcastNestedLoopJoin sho...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9351#issuecomment-152145650 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11188][SQL][WIP] Elide stacktraces in b...

2015-10-29 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9194#issuecomment-152145556 This LGTM, can you update the title (remove WIP) and update the description (it will be come the commit message when merging). --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

2015-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11400][SQL] BroadcastNestedLoopJoin sho...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9351#issuecomment-152145629 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11400][SQL] BroadcastNestedLoopJoin sho...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9351#issuecomment-152146975 **[Test build #44587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44587/consoleFull)** for PR 9351 at commit

[GitHub] spark pull request: [SPARK-11235] [network] Add ability to stream ...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9206#issuecomment-152148484 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11235] [network] Add ability to stream ...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9206#issuecomment-152148360 **[Test build #44584 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44584/consoleFull)** for PR 9206 at commit

[GitHub] spark pull request: [SPARK-11235] [network] Add ability to stream ...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9206#issuecomment-152148481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43372849 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -374,26 +374,53 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11388][Build]Fix self closing tags.

2015-10-29 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9339#issuecomment-152149315 probably unrelated. this change shouldn't really cause any test failures. retest this please --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43372906 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -374,26 +374,53 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11393][SQL] CoGroupedIterator should re...

2015-10-29 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9346#issuecomment-152149587 I'm a little confused. If `GroupedIterator.hasNext` isn't idempotent then we should fix that instead of working around it. However, as of master I wasn't able to

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373075 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1793,10 +1793,11 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-11388][Build]Fix self closing tags.

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9339#issuecomment-152149978 **[Test build #44588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44588/consoleFull)** for PR 9339 at commit

[GitHub] spark pull request: [SPARK-11388][Build]Fix self closing tags.

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9339#issuecomment-152149760 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373109 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -374,26 +374,53 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11388][Build]Fix self closing tags.

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9339#issuecomment-152149784 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373183 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -374,26 +374,53 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373327 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -374,26 +374,53 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373370 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -639,7 +666,20 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373445 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -639,7 +666,20 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373477 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala --- @@ -639,7 +666,20 @@ abstract class DStream[T: ClassTag] (

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373528 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/ForEachDStream.scala --- @@ -22,10 +22,19 @@ import

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

2015-10-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9315#discussion_r43373566 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/DStreamScopeSuite.scala --- @@ -17,10 +17,13 @@ package

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-10-29 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-152396959 Will `SparkSubmitSuite` help? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-10-29 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-152402475 How about this. In the main method, you can catch the exception and if it is the expected type, let the main method finish successfully. Otherwise, throw an exception,

[GitHub] spark pull request: [SPARK-7970] Skip closure cleaning for SQL ope...

2015-10-29 Thread nitin2goyal
Github user nitin2goyal commented on the pull request: https://github.com/apache/spark/pull/9253#issuecomment-152402420 Thanks fore reviewing Andrew ( @andrewor14 ). Have addressed your comments. Let me know if it looks good. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-11409][SPARKR] Enable url link in R doc...

2015-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9371#issuecomment-152417238 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9371#issuecomment-152417221 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11417] [SQL] no @Override in codegen

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9372#issuecomment-152417217 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11024][SQL] Optimize NULL in

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9348#issuecomment-152420766 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10890][SQL] don't log expected JdbcSQLE...

2015-10-29 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9345#issuecomment-152421377 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11024][SQL] Optimize NULL in

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9348#issuecomment-152420710 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10971][SPARKR] RRunner should allow set...

2015-10-29 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9179#issuecomment-152407168 @msannell, good catch. Thanks! I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11273][SQL] Move ArrayData/MapData/Data...

2015-10-29 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9239#issuecomment-152407939 Are you sure your local master branch is latest and clean? This PR has been merge for a week and everything goes well so far. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-10890][SQL] don't log expected JdbcSQLE...

2015-10-29 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9345#issuecomment-152421379 It's a known flaky test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11024][SQL] Optimize NULL in

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9348#issuecomment-152421507 **[Test build #44662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44662/consoleFull)** for PR 9348 at commit

[GitHub] spark pull request: [SPARK-11024][SQL] Optimize NULL in

2015-10-29 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/9348#issuecomment-152422271 @cloud-fan Thanks.. have updated the test case name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-11410] [SQL] Add APIs to provide functi...

2015-10-29 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9364#discussion_r43467527 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -987,4 +992,116 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11410] [SQL] Add APIs to provide functi...

2015-10-29 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9364#discussion_r43467544 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -987,4 +992,116 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-152395201 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10327][SQL] Cache Table is not working ...

2015-10-29 Thread mbautin
Github user mbautin commented on a diff in the pull request: https://github.com/apache/spark/pull/8494#discussion_r43467362 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -135,16 +135,25 @@ abstract class LogicalPlan

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-152395199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11410] [SQL] Add APIs to provide functi...

2015-10-29 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9364#issuecomment-152396487 How about we update the title to `[SPARK-11410] [SQL] Add APIs to provide functionality similar to Hive's DISTRIBUTE BY and SORT BY`? --- If your project is set up for

[GitHub] spark pull request: [SPARK-11024][SQL] Optimize NULL in

2015-10-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9348#discussion_r43469995 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -417,6 +417,11 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-11301][SQL] fix case sensitivity for fi...

2015-10-29 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9271#issuecomment-152411242 This part of code has been changed a lot by https://github.com/apache/spark/pull/8916/files , should we backport that too? --- If your project is set up for it, you

[GitHub] spark pull request: SPARK-11326: Split networking in standalone mo...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9287#issuecomment-152414208 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-11415: Remove timezone shift of Catalyst...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9369#issuecomment-152414238 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-152415520 [Test build #44655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44655/console) for PR 9367 at commit

[GitHub] spark pull request: [SPARK-11236][CORE] Update Tachyon dependency ...

2015-10-29 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/9204#issuecomment-152415593 @haoyuan hey HY - can you not merge build related patches without asking for feedback from one of the build maintainers (me or @srowen)? This patch makes changes to

[GitHub] spark pull request: [SPARK-11396] [SQL] add native implementation ...

2015-10-29 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/9347#issuecomment-152415697 @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10186][SQL] Array types using JDBCRDD a...

2015-10-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/9137#discussion_r43472350 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -207,6 +225,25 @@ case object PostgresDialect extends JdbcDialect {

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9370 [SPARK-10829][SPARK-11301][SQL] backport to branch 1.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark branch-1.5

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/9370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10890][SQL] don't log expected JdbcSQLE...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9345#issuecomment-152423996 **[Test build #44663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44663/consoleFull)** for PR 9345 at commit

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-152395101 **[Test build #44651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44651/consoleFull)** for PR 9366 at commit

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9371#issuecomment-152417609 @cloud-fan Can you change the title to a more informative one? It will be helpful to people looking at our commit log. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-9858][SPARK-9859][SPARK-9861][SQL] Add ...

2015-10-29 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9276#discussion_r43473235 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExchangeCoordinator.scala --- @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9327#issuecomment-152424940 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152399627 **[Test build #44652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44652/consoleFull)** for PR 9241 at commit

[GitHub] spark pull request: [SPARK-11417] [SQL] no @Override in codegen

2015-10-29 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/9372 [SPARK-11417] [SQL] no @Override in codegen Older version of Janino (>2.7) does not support @Override, we should not use that in codegen. You can merge this pull request into a Git repository by

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9371#issuecomment-152417123 cc @yhuai @chenghao-intel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9371 [SPARK-10829][SPARK-11301][SQL] backport to branch 1.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark branch-1.5

[GitHub] spark pull request: [SPARK-11417] [SQL] no @Override in codegen

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9372#issuecomment-152417239 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11417] [SQL] no @Override in codegen

2015-10-29 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9372#issuecomment-152417127 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10890][SQL] don't log expected JdbcSQLE...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9345#issuecomment-152423150 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10890][SQL] don't log expected JdbcSQLE...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9345#issuecomment-152423194 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9327#issuecomment-152432034 **[Test build #44664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44664/consoleFull)** for PR 9327 at commit

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152400814 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-10-29 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r43468563 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -17,17 +17,17 @@ package

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-10-29 Thread choochootrain
Github user choochootrain commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-152398230 `SparkSubmitSuite` is helpful, but I want to catch and assert the type of exception that is thrown when the job fails - calling into `doMain` in

[GitHub] spark pull request: [SPARK-10890][SQL] don't log expected JdbcSQLE...

2015-10-29 Thread ckadner
Github user ckadner commented on the pull request: https://github.com/apache/spark/pull/9345#issuecomment-152400158 Hi @JoshRosen, the failing unit test `"Single command with -e"` in `CliSuite` should not be impacted by my changes. On my machine I get the timeouts with or without my

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152399804 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152400875 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152399801 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11329] [SQL] Support star expansion for...

2015-10-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9343#discussion_r43470847 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1870,4 +1870,66 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11414][SPARKR] Forgot to update usage o...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9368#issuecomment-152414425 **[Test build #44658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44658/consoleFull)** for PR 9368 at commit

[GitHub] spark pull request: [SPARK-9298][SQL] Add pearson correlation aggr...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8587#issuecomment-152415818 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11410] [SQL] Add APIs to provide functi...

2015-10-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/9364#discussion_r43471991 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -987,4 +992,116 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-9298][SQL] Add pearson correlation aggr...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8587#issuecomment-152415834 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-11415: Remove timezone shift of Catalyst...

2015-10-29 Thread jacek-lewandowski
Github user jacek-lewandowski commented on the pull request: https://github.com/apache/spark/pull/9369#issuecomment-152417671 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9858][SPARK-9859][SPARK-9861][SQL] Add ...

2015-10-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/9276#discussion_r43473446 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExchangeCoordinator.scala --- @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152403185 **[Test build #44656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44656/consoleFull)** for PR 9241 at commit

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-152415573 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-152415572 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

2015-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9327#issuecomment-152424928 @liancheng oh, right. I just added at `ParquetFilterSuite` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9327#issuecomment-152424957 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11024][SQL] Optimize NULL in

2015-10-29 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9348#issuecomment-152424961 LGTM, pending test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11414][SPARKR] Forgot to update usage o...

2015-10-29 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9368#issuecomment-152414716 LGTM. Thanks @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9298][SQL] Add pearson correlation aggr...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8587#issuecomment-152416560 **[Test build #44659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44659/consoleFull)** for PR 8587 at commit

[GitHub] spark pull request: [SPARK-10829][SPARK-11301][SQL] backport to br...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9371#issuecomment-152419123 [Test build #44661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44661/consoleFull) for PR 9371 at commit

[GitHub] spark pull request: [SPARK-11417] [SQL] no @Override in codegen

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9372#issuecomment-152420060 **[Test build #44660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44660/consoleFull)** for PR 9372 at commit

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152373451 **[Test build #44644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44644/consoleFull)** for PR 9241 at commit

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152373513 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9241#issuecomment-152373511 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10849][SQL] Adding field metadata prope...

2015-10-29 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/9352#issuecomment-152373735 Thinking about this more , I realized current version of the patch may introduce SQL injection. I will update the pull request with a new version of the fix.

<    4   5   6   7   8   9   10   >