[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-177611868 **[Test build #50464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50464/consoleFull)** for PR 10957 at commit

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-177611990 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-177611987 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177664921 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177664927 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13105] Reject NATURAL JOIN queries rath...

2016-01-31 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/10997 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13105] Reject NATURAL JOIN queries rath...

2016-01-31 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10997#issuecomment-177604554 Argh, that's annoying. I guess I'll go ahead and close this PR and resolve the JIRA issue as "Not a Problem". --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177631538 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177631536 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177662189 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177666934 **[Test build #50467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50467/consoleFull)** for PR 10987 at commit

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-177581562 Thanks - only some minor comment on the documentation to make it more clear. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-177628340 Thanks - merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10957 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10957#discussion_r51365127 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -349,19 +349,41 @@ object functions extends LegacyFunctions { }

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-177596521 **[Test build #50464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50464/consoleFull)** for PR 10957 at commit

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r51372548 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -453,3 +455,119 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-12988][SQL] Can't drop columns that con...

2016-01-31 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10943#issuecomment-177815884 @cloud-fan Thank you Wenchen. I will try your suggestion and get back. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177816589 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13078][SQL] Infrastructure for the inte...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51385382 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13078][SQL] Infrastructure for the inte...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51385263 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177816310 **[Test build #50476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50476/consoleFull)** for PR 10762 at commit

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177816588 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177824351 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177810925 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177810918 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177814472 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177814287 **[Test build #50473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50473/consoleFull)** for PR 10942 at commit

[GitHub] spark pull request: SPARK-13052 waitingApps metric doesn't show th...

2016-01-31 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/10959#discussion_r51385540 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/MasterSource.scala --- @@ -42,6 +42,6 @@ private[spark] class MasterSource(val master:

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177824349 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177823853 **[Test build #50477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50477/consoleFull)** for PR 10964 at commit

[GitHub] spark pull request: [SPARK-12705] [SPARK-10777] [SQL] Analyzer Rul...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10678#issuecomment-177827371 **[Test build #50479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50479/consoleFull)** for PR 10678 at commit

[GitHub] spark pull request: [SPARK-12437][SQL] [WIP]Encapsulate the table ...

2016-01-31 Thread naveenminchu
Github user naveenminchu commented on a diff in the pull request: https://github.com/apache/spark/pull/10403#discussion_r51382164 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala --- @@ -40,6 +40,34 @@ private case object MySQLDialect extends

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177786658 **[Test build #50477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50477/consoleFull)** for PR 10964 at commit

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177805324 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10762#discussion_r51385913 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveNaturalJoinSuite.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/10964#discussion_r51381272 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2056,4 +2056,11 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-01-31 Thread mariobriggs
Github user mariobriggs commented on a diff in the pull request: https://github.com/apache/spark/pull/10953#discussion_r51381737 --- Diff: external/kafka-assembly/pom.xml --- @@ -43,6 +43,11 @@ org.apache.spark +

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177805456 Merging into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-177809381 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177809942 **[Test build #50474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50474/consoleFull)** for PR 10964 at commit

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-177809359 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13078][SQL] Infrastructure for the inte...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51385070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177814471 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177670230 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r51372158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -453,3 +455,119 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-13078][SQL] Infrastructure for the inte...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51372504 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13078][SQL] Infrastructure for the inte...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51372519 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r51372496 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -453,3 +455,119 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-177754404 **[Test build #50472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50472/consoleFull)** for PR 10964 at commit

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177763082 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10762#discussion_r51380099 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveNaturalJoinSuite.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-15469 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-15757 **[Test build #50472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50472/consoleFull)** for PR 10964 at commit

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177673970 **[Test build #50469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50469/consoleFull)** for PR 10987 at commit

[GitHub] spark pull request: [Minor] [ML] [PySpark] Cleanup test cases of c...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10975#issuecomment-177748147 **[Test build #50471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50471/consoleFull)** for PR 10975 at commit

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-177765366 **[Test build #50473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50473/consoleFull)** for PR 10942 at commit

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-15879 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177694894 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177694386 **[Test build #50469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50469/consoleFull)** for PR 10987 at commit

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177694890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12966][SQL] ArrayType(DecimalType) supp...

2016-01-31 Thread blbradley
Github user blbradley commented on the pull request: https://github.com/apache/spark/pull/10928#issuecomment-177720072 ping @JoshRosen What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Minor] [ML] [PySpark] Cleanup test cases of c...

2016-01-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10975#issuecomment-177743797 @mengxr I did not found other class has similar test except ```KMeans```, is this deliberately designed or lacks of some test cases? --- If your project is set up

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/10964#discussion_r51380304 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2056,4 +2056,11 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10964#discussion_r51380297 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2056,4 +2056,11 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10964#issuecomment-14248 **[Test build #50474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50474/consoleFull)** for PR 10964 at commit

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177670229 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r51371194 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -453,3 +455,119 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [Minor] [ML] [PySpark] Cleanup test cases of c...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10975#issuecomment-177753240 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-16701 **[Test build #50476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50476/consoleFull)** for PR 10762 at commit

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177676236 **[Test build #50467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50467/consoleFull)** for PR 10987 at commit

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177676251 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13093][SQL] improve null check in nullS...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10987#issuecomment-177676250 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13035] [ML] [PySpark] PySpark ml.cluste...

2016-01-31 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/10999#discussion_r51371337 --- Diff: python/pyspark/ml/clustering.py --- @@ -69,6 +70,25 @@ class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177719375 **[Test build #50470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50470/consoleFull)** for PR 10762 at commit

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177751979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177751426 **[Test build #50470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50470/consoleFull)** for PR 10762 at commit

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-177751977 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10964#discussion_r51379478 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2056,4 +2056,11 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11780][SQL] Add catalyst type aliases b...

2016-01-31 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10915#issuecomment-177766651 @marmbrus Okay and could you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Docs] Fix the jar location of datanucleus in ...

2016-01-31 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10901#issuecomment-177766766 @marmbrus ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2016-01-31 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10388#issuecomment-177674881 Cherry-picked to branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13078][SQL] Infrastructure for the inte...

2016-01-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51372473 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13035] [ML] [PySpark] PySpark ml.cluste...

2016-01-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10999#discussion_r51375854 --- Diff: python/pyspark/ml/clustering.py --- @@ -69,6 +70,25 @@ class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol

[GitHub] spark pull request: [Minor] [ML] [PySpark] Cleanup test cases of c...

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10975#issuecomment-177753237 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Minor] [ML] [PySpark] Cleanup test cases of c...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10975#issuecomment-177753016 **[Test build #50471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50471/consoleFull)** for PR 10975 at commit

[GitHub] spark pull request: [SPARK-13056][SQL] map column would throw NPE ...

2016-01-31 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/10964#discussion_r51380186 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2056,4 +2056,11 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-15471 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12705] [SPARK-10777] [SQL] Analyzer Rul...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10678#issuecomment-177429382 **[Test build #50459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50459/consoleFull)** for PR 10678 at commit

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-01-31 Thread ygcao
Github user ygcao commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-177429666 Adopted all Sean's suggestions with minor editing to address missed edge case and make compiler happy, I think these suggestions are good ones, thanks!. please try to

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-31 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177434727 @jayadevanmurali please don't close the PR, your fix is valid. We really shouldn't use table names like ```t~``` unless they are quoted using backticks. Please

[GitHub] spark pull request: [ML][MINOR] Invalid MulticlassClassification r...

2016-01-31 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10996#issuecomment-177439592 cool, verified the link against the current API docs would be good to have fixed. Maybe @mengxr can take a quick look? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-01-31 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-177442867 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13105] Reject NATURAL JOIN queries rath...

2016-01-31 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10997#issuecomment-177442161 Hive does not have a ```NATURAL``` keyword. It behaves the same as the old SqlParser: - It will either treat ```NATURAL``` the alias of the previous table,

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-01-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-177446928 **[Test build #50460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50460/consoleFull)** for PR 10998 at commit

[GitHub] spark pull request: [SPARK-12705] [SPARK-10777] [SQL] Analyzer Rul...

2016-01-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10678#discussion_r51357541 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -521,38 +522,99 @@ class Analyzer( */

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-31 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177447251 Thanks @hvanhovell, Working on test case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-01-31 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10983#issuecomment-177448445 @jayadevanmurali could you add the test to ```DataFrameSuite``` instead of ```SQLQuerySuite```? Sorry about the confusion. --- If your project is set up for it,

  1   2   >