[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202968892 **[Test build #54443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54443/consoleFull)** for PR 11991 at commit

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57748633 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -385,9 +385,9 @@ abstract class OutputWriter { * *

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202998070 **[Test build #54445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54445/consoleFull)** for PR 12039 at commit

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid using compo...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12038#issuecomment-202948797 **[Test build #54441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54441/consoleFull)** for PR 12038 at commit

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57747923 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -91,6 +93,46 @@ class DefaultSource extends

[GitHub] spark pull request: [SPARK-13382][DOCS][PYSPARK] Update pyspark te...

2016-03-29 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11278#issuecomment-202976430 Ok - I can close this if we think thats going to be fixed soon (e.g. before the next release). --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-14210][SQL] Add a metric for time spent...

2016-03-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/12007#discussion_r57756896 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala --- @@ -241,73 +256,89 @@ private[sql] case class DataSourceScan(

[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...

2016-03-29 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12017#issuecomment-202991498 @davies Yea. The format allows at most 1 dictionary per column per row group. Each page can have a different encoding though. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-9695] [ML] Add random seed Param to ML ...

2016-03-29 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/9158#discussion_r57759943 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala --- @@ -100,6 +101,15 @@ class Pipeline(override val uid: String) extends

[GitHub] spark pull request: [SPARK-14244][SQL][WIP] Don't use SizeBasedWin...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12040#issuecomment-202997658 **[Test build #54448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54448/consoleFull)** for PR 12040 at commit

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/12039 [SPARK-14059] [ML] [SparkR] Define and use KMeansWrapper for SparkR::kmeans ## What changes were proposed in this pull request? Define and use ```KMeansWrapper``` for ```SparkR::kmeans```.

[GitHub] spark pull request: [SPARK-14244][SQL][WIP] Don't use SizeBasedWin...

2016-03-29 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/12040 [SPARK-14244][SQL][WIP] Don't use SizeBasedWindowFunction.n created on executor side when evaluating window functions ## What changes were proposed in this pull request?

[GitHub] spark pull request: [SPARK-14244][SQL][WIP] Don't use SizeBasedWin...

2016-03-29 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/12040#issuecomment-202997227 Just came to a simpler and less error prone solution after opening this PR: we may reserve an expression ID range, say 0 ~ 1024, for predefined global attribute

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid using compo...

2016-03-29 Thread liyezhang556520
GitHub user liyezhang556520 opened a pull request: https://github.com/apache/spark/pull/12038 [SPARK-14242][CORE][Network] avoid using compositeBuffer for frame decoder ## What changes were proposed in this pull request? In this patch, we avoid using `compositeBuffer` in

[GitHub] spark pull request: [SPARK-14154] [MLlib] Simplify the implementat...

2016-03-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11954#issuecomment-202981052 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-29 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/11326#discussion_r57752853 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala --- @@ -69,6 +69,8 @@ private[spark] object

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57759347 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -91,6 +93,46 @@ class DefaultSource extends

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57760761 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala --- @@ -49,14 +49,10 @@ object CSVRelation extends

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-202961179 **[Test build #54442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54442/consoleFull)** for PR 12036 at commit

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-202962322 **[Test build #54442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54442/consoleFull)** for PR 12036 at commit

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-202962331 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-202962334 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202973142 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202973138 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-03-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-202981864 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14154] [MLlib] Simplify the implementat...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11871#issuecomment-202981940 **[Test build #54446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54446/consoleFull)** for PR 11871 at commit

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57755370 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala --- @@ -49,14 +49,10 @@ object CSVRelation extends

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-29 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-202995487 That seems like a pretty reasonable change, although it might be good to add a regression test. Maybe @davies or @JoshRosen can verify this patch for Jenkins? --- If

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57759763 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -385,9 +385,9 @@ abstract class OutputWriter { * *

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid using compo...

2016-03-29 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/12038#discussion_r57741705 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportFrameDecoder.java --- @@ -139,14 +139,18 @@ private ByteBuf

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57748886 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -112,8 +105,9 @@ private[sql] object

[GitHub] spark pull request: [SPARK-14164][MLLIB] Improve input layer valid...

2016-03-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11964#issuecomment-202972522 Thank you, @MLnick . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202972705 **[Test build #5 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 12039 at commit

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-03-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11871#issuecomment-202979360 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-202948702 The failed tests are due to describe function DDL command. Let me fix it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid using compo...

2016-03-29 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/12038#discussion_r57742478 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportFrameDecoder.java --- @@ -139,14 +139,18 @@ private ByteBuf

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11326#discussion_r57747605 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala --- @@ -69,6 +69,8 @@ private[spark] object

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57747564 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -112,8 +105,9 @@ private[sql] object

[GitHub] spark pull request: [SPARK-12334][SQL][PYSPARK] Support read from ...

2016-03-29 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/10307#discussion_r57751258 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala --- @@ -164,6 +165,14 @@ class OrcQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202981925 **[Test build #54445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54445/consoleFull)** for PR 12039 at commit

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-202983735 **[Test build #54447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54447/consoleFull)** for PR 11876 at commit

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202998298 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202998296 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57760192 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala --- @@ -49,14 +49,10 @@ object CSVRelation extends

[GitHub] spark pull request: [SPARK-14059] [ML] [SparkR] Define and use KMe...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-202973132 **[Test build #5 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 12039 at commit

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-29 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57760314 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -112,8 +105,9 @@ private[sql] object

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-29 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202726994 @mengxr This was actually easier when ```labels``` was stored as a Param; that made save/load handle it automatically. I just changed it to store labels as a

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-29 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11517#issuecomment-202727113 @davies This is rebased. Please take a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202727216 **[Test build #54413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54413/consoleFull)** for PR 11983 at commit

[GitHub] spark pull request: [Spark-14230][STREAMING] Config the start time...

2016-03-29 Thread liyintang
Github user liyintang commented on the pull request: https://github.com/apache/spark/pull/12026#issuecomment-203010916 I thought the back pressure/flow control handles how many message to fetch, not when to start to generate the job. IMHO, adding the jitter in the start time is more

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12036#discussion_r57770133 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -86,13 +87,50 @@ case class DescribeDatabase(

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12016#discussion_r57773320 --- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala --- @@ -21,5 +21,20 @@ package org.apache.spark.partial * A Double value with

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10900#issuecomment-203038434 also cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

2016-03-29 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/11996#issuecomment-203061970 sorry haven't had time to look at this yet, hopefully in a day or so --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57787998 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends AstBuilder

[GitHub] spark pull request: SPARK-14139 Dataset loses nullability in opera...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11980#issuecomment-203069529 **[Test build #54457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54457/consoleFull)** for PR 11980 at commit

[GitHub] spark pull request: [MINOR][SQL] Fix typos by replacing 'much' wit...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11987#discussion_r57791722 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala --- @@ -29,22 +29,26 @@ import

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11987#discussion_r57792823 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala --- @@ -29,22 +29,26 @@ import

[GitHub] spark pull request: [SPARK-14181] TrainValidationSplit should have...

2016-03-29 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11985#issuecomment-203062646 Could you please modify a unit test to set the seed so we test this code path? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-29 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-203065118 There are some integration tests hosted in an separate repo by the Databricks people at https://github.com/databricks/spark-integration-tests , I'm not super sure on

[GitHub] spark pull request: [SPARK-14227] [SQL] Add method for printing ou...

2016-03-29 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12025#issuecomment-203067133 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57786921 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4 --- @@ -107,7 +107,8 @@ statement | DROP TEMPORARY?

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57787715 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends AstBuilder

[GitHub] spark pull request: [MINOR][SQL] Fix exception message to print st...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12041#issuecomment-203068919 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][SQL] Fix typos by replacing 'much' wit...

2016-03-29 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12042#issuecomment-203068947 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13992][WIP] Add support for off-heap ca...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-203076036 ttp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11987#discussion_r57792101 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala --- @@ -29,22 +29,26 @@ import

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12036#discussion_r57793017 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -21,27 +21,28 @@ import

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-29 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/10355#discussion_r57768696 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala --- @@ -17,14 +17,116 @@ package org.apache.spark.ml.util

[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12029#issuecomment-203030872 Thanks, merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-03-29 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-203039591 do we have a test case for data that some of them fit in a decimal and some don't? i want to make sure we have a rule to coerce decimal + double into just

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-03-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12030#discussion_r57774941 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala --- @@ -135,11 +136,15 @@ private[sql] object InferSchema

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-203017554 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13931] Resolve stage hanging up problem...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11760#issuecomment-203033853 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13931] Resolve stage hanging up problem...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11760#issuecomment-203034733 **[Test build #54450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54450/consoleFull)** for PR 11760 at commit

[GitHub] spark pull request: [MINOR][SQL] Fix typos by replacing 'much' wit...

2016-03-29 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12042 [MINOR][SQL] Fix typos by replacing 'much' with 'match'. ## What changes were proposed in this pull request? This PR fixes two trivial typos: 'does not **much**' --> 'does not

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-203042616 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-203042612 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-203042353 **[Test build #54447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54447/consoleFull)** for PR 11876 at commit

[GitHub] spark pull request: [SPARK-14239] [ML] Add load for LDAModel that ...

2016-03-29 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12034#issuecomment-203057456 I think you'll need to close this PR manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14225][SQL] Cap the length of toComment...

2016-03-29 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12044#issuecomment-203060691 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14225][SQL] Cap the length of toComment...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12044#issuecomment-203061535 **[Test build #54455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54455/consoleFull)** for PR 12044 at commit

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-29 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-203061073 I made a JIRA: https://issues.apache.org/jira/browse/SPARK-14249 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14181] TrainValidationSplit should have...

2016-03-29 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11985#issuecomment-203068427 Sure, will do it soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][SQL] Fix exception message to print st...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12041#issuecomment-203068543 **[Test build #54449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54449/consoleFull)** for PR 12041 at commit

[GitHub] spark pull request: [Spark-13784][ML][WIP] Model export/import for...

2016-03-29 Thread GayathriMurali
Github user GayathriMurali commented on a diff in the pull request: https://github.com/apache/spark/pull/12023#discussion_r57787829 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala --- @@ -240,12 +250,66 @@ final class

[GitHub] spark pull request: [MINOR][SQL] Fix exception message to print st...

2016-03-29 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12041#issuecomment-203069324 @dongjoon-hyun it might be good if you can batch of these typos or minor cleansup into a single pr in the future. Thanks! Merging in master. --- If your

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57788225 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends AstBuilder {

[GitHub] spark pull request: [SPARK-14225][SQL] Cap the length of toComment...

2016-03-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12044#discussion_r57788333 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala --- @@ -49,8 +49,11 @@ private class CodeFormatter

[GitHub] spark pull request: [Spark-13784][ML][WIP] Model export/import for...

2016-03-29 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12023#discussion_r57788687 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala --- @@ -240,12 +250,66 @@ final class

[GitHub] spark pull request: [SPARK-12343][YARN] Simplify Yarn client and c...

2016-03-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11603#discussion_r57788838 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMasterArguments.scala --- @@ -101,12 +91,8 @@ class ApplicationMasterArguments(val

[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12017#issuecomment-203072990 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57789745 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -350,6 +354,34 @@ case class

[GitHub] spark pull request: [SPARK-13931] Resolve stage hanging up problem...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11760#issuecomment-203087196 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][SQL] Fix typos by replacing 'much' wit...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12042#issuecomment-203087215 **[Test build #54452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54452/consoleFull)** for PR 12042 at commit

[GitHub] spark pull request: [SPARK-13931] Resolve stage hanging up problem...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11760#issuecomment-203087194 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-29 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57795477 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -350,6 +354,34 @@ case class

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12004#issuecomment-203103180 **[Test build #54454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54454/consoleFull)** for PR 12004 at commit

  1   2   3   4   5   6   7   >