[GitHub] spark pull request #14593: [MINOR][DOC] Fix style in examples across documen...

2016-08-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14593#discussion_r74400900 --- Diff: docs/streaming-programming-guide.md --- @@ -1142,12 +1142,12 @@ val joinedStream = windowedStream.transform { rdd => rdd.join(dataset) }

[GitHub] spark pull request #14593: [MINOR][DOC] Fix style in examples across documen...

2016-08-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14593#discussion_r74401530 --- Diff: docs/graphx-programming-guide.md --- @@ -235,8 +235,9 @@ triplet view of a graph to render a collection of strings describing relationshi

[GitHub] spark issue #14602: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14602 **[Test build #63607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63607/consoleFull)** for PR 14602 at commit

[GitHub] spark pull request #14598: [SPARK-17018][SQL] literals.sql for testing liter...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14598#discussion_r74402656 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -0,0 +1,136 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #63605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63605/consoleFull)** for PR 14102 at commit

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74413499 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #14603: [SPARK-17021][SQL] simplify the constructor parameters o...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14603 **[Test build #63609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63609/consoleFull)** for PR 14603 at commit

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14102 Thanks for reviewing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14601: [SPARK-13979][Spark Core][WIP]Killed executor is ...

2016-08-11 Thread agsachin
GitHub user agsachin opened a pull request: https://github.com/apache/spark/pull/14601 [SPARK-13979][Spark Core][WIP]Killed executor is re spawned without AWS key… ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix)

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63602/ Test PASSed. ---

[GitHub] spark pull request #14598: [SPARK-17018][SQL] literals.sql for testing liter...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14598#discussion_r74403321 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -0,0 +1,136 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74404348 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #14600: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14600 **[Test build #63604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63604/consoleFull)** for PR 14600 at commit

[GitHub] spark issue #12896: [SPARK-14489][ML][PYSPARK] ALS unknown user/item predict...

2016-08-11 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/12896 @srowen @jkbradley any further comments / issues? I plan to create follow-up JIRAs for docs & examples, as well as expansions to the cold-start strategies. also cc @mengxr @yanboliang for

[GitHub] spark issue #14600: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14600 Thanks @avulanov for the follow up. Merging to 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-11 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/14546 I believe this doesn't fix all the cases. How about ``` sql("select count(*), a from (select 1 as a) tmp group by 2 having a > 0").show ``` --- If your project is set up for

[GitHub] spark pull request #14581: Correct example value for spark.ssl.YYY.XXX setti...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14524: [SPARK-16832] [ML] [WIP] CrossValidator and TrainValidat...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14524 @mengxr do you happen to have an opinion on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14491: [SPARK-16886] [EXAMPLES][SQL] structured streamin...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14564: [SPARK-16886][EXAMPLES][DOC] Fix some examples to...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63599/ Test PASSed. ---

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14601: [SPARK-13979][Spark Core][WIP]Killed executor is re spaw...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14601 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14602: [SPARK-16966] [SQL] [CORE] App Name is a randomUU...

2016-08-11 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/14602 [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even when "spark.app.name" exists ## What changes were proposed in this pull request? Don't override spark.app.name in SparkSession when

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63606/ Test PASSed. ---

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74404978 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #14600: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14600 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63604/ Test PASSed. ---

[GitHub] spark issue #14600: [SPARK-15899] [SQL] Fix the construction of the file pat...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14600 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #63605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63605/consoleFull)** for PR 14102 at commit

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 Let's close this in favor of https://github.com/apache/spark/pull/14564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #63602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63602/consoleFull)** for PR 14102 at commit

[GitHub] spark issue #14602: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14602 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14602: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14602 **[Test build #63607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63607/consoleFull)** for PR 14602 at commit

[GitHub] spark issue #14602: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14602 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63607/ Test FAILed. ---

[GitHub] spark pull request #14603: [SPARK-17021][SQL] simplify the constructor param...

2016-08-11 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/14603 [SPARK-17021][SQL] simplify the constructor parameters of QuantileSummaries ## What changes were proposed in this pull request? 1. `sampled` doesn't need to be `ArrayBuffer`, we never

[GitHub] spark pull request #14599: [SPARK-17013][SQL] handle corner case for negativ...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14599#discussion_r74423461 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -627,6 +627,7 @@ quotedIdentifier number :

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74400488 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark pull request #14552: [SPARK-16952] don't lookup spark home directory w...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63608/consoleFull)** for PR 14593 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14559 This is looking good. I'm not as familiar with the Python API but it doesn't seem like this needs a change in an API anywhere, Scala or Python. So I think this is OK. --- If your project is set up

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14559 +1 for both OK and not exposing `JDBCOptions`. I know it is slightly different but `CSVoptions` and `JSONOptions` would be good references to follow. --- If your project is set up for it, you

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74412725 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #14603: [SPARK-17021][SQL] simplify the constructor parameters o...

2016-08-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14603 cc @thunterdb @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14598: [SPARK-17018][SQL] literals.sql for testing liter...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14598#discussion_r74424129 --- Diff: sql/core/src/test/resources/sql-tests/inputs/literals.sql --- @@ -0,0 +1,52 @@ +-- Literal parsing + +-- null +select null;

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74400235 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63605/ Test PASSed. ---

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74416260 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #63599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63599/consoleFull)** for PR 14102 at commit

[GitHub] spark issue #14564: [SPARK-16886][EXAMPLES][DOC] Fix some examples to be con...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14564 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #14598: [SPARK-17018][SQL] literals.sql for testing liter...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14598#discussion_r74403147 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -0,0 +1,136 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark issue #14530: [SPARK-16868][Web Ui] Fix executor be both dead and aliv...

2016-08-11 Thread SaintBacchus
Github user SaintBacchus commented on the issue: https://github.com/apache/spark/pull/14530 \cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14581: Correct example value for spark.ssl.YYY.XXX settings

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14581 merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63606/consoleFull)** for PR 14593 at commit

[GitHub] spark issue #14552: [SPARK-16952] don't lookup spark home directory when exe...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14552 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63606/consoleFull)** for PR 14593 at commit

[GitHub] spark issue #14534: [SPARK-16941]Use concurrentHashMap instead of scala Map ...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14534 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #14534: [SPARK-16941]Use concurrentHashMap instead of sca...

2016-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14593: [MINOR][DOC] Fix style in examples across documen...

2016-08-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14593#discussion_r74401289 --- Diff: docs/graphx-programming-guide.md --- @@ -235,8 +235,9 @@ triplet view of a graph to render a collection of strings describing relationshi val

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63608/consoleFull)** for PR 14593 at commit

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63608/ Test PASSed. ---

[GitHub] spark issue #14548: [SPARK-16958] [SQL] Reuse subqueries within the same que...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14548 Cool picture! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14593: [MINOR][DOC] Fix style in examples across documentation

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14593 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14530: [SPARK-16868][Web Ui] Fix executor be both dead and aliv...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14530 As to the actual logic of the change, I don't feel that confident about reviewing it. Suggest looking at 'blame' output here to see who might have written it? --- If your project is set up for it,

[GitHub] spark pull request #14548: [SPARK-16958] [SQL] Reuse subqueries within the s...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14548#discussion_r74427941 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala --- @@ -17,42 +17,77 @@ package org.apache.spark.sql.execution

[GitHub] spark issue #14548: [SPARK-16958] [SQL] Reuse subqueries within the same que...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14548 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63611/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63616/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14586: [SPARK-17003] [BUILD] [BRANCH-1.6] release-build.sh is m...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14586 **[Test build #3219 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3219/consoleFull)** for PR 14586 at commit

[GitHub] spark issue #14586: [SPARK-17003] [BUILD] [BRANCH-1.6] release-build.sh is m...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14586 **[Test build #3218 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3218/consoleFull)** for PR 14586 at commit

[GitHub] spark issue #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/cache() s...

2016-08-11 Thread nchammas
Github user nchammas commented on the issue: https://github.com/apache/spark/pull/14579 Hmm, OK I see. (Apologies, I don't understand what pipelined RDDs are for, so the examples are going a bit over my head. 😅) --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #14602: [SPARK-16966] [SQL] [CORE] App Name is a randomUUID even...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14602 **[Test build #63610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63610/consoleFull)** for PR 14602 at commit

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB] add a chiSquare Selector bas...

2016-08-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r74437070 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -197,3 +197,28 @@ class ChiSqSelector @Since("1.3.0") ( new

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13373 **[Test build #63612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63612/consoleFull)** for PR 13373 at commit

[GitHub] spark issue #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/cache() s...

2016-08-11 Thread nchammas
Github user nchammas commented on the issue: https://github.com/apache/spark/pull/14579 > So there is no chaining requirement, and it will only work in a with statement. @MLnick - Couldn't we also create a scenario (like @holdenk did earlier) where a user does something like

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13373 **[Test build #63612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63612/consoleFull)** for PR 13373 at commit

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13373 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63612/ Test FAILed. ---

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13373 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #14601: [SPARK-13979][Spark Core][WIP]Killed executor is ...

2016-08-11 Thread lresende
Github user lresende commented on a diff in the pull request: https://github.com/apache/spark/pull/14601#discussion_r74440796 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -107,6 +107,14 @@ class SparkHadoopUtil extends Logging {

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74442456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +42,23 @@ import

[GitHub] spark pull request #14604: [Doc] add config option spark.ui.enabled into doc...

2016-08-11 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/14604 [Doc] add config option spark.ui.enabled into document ## What changes were proposed in this pull request? The configuration doc lost the config option `spark.ui.enabled` (default

[GitHub] spark pull request #14604: [Doc] add config option spark.ui.enabled into doc...

2016-08-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14604#discussion_r7575 --- Diff: docs/configuration.md --- @@ -568,6 +568,13 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #14598: [SPARK-17018][SQL] literals.sql for testing liter...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14598#discussion_r74427705 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -0,0 +1,148 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74436746 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +93,12 @@ case class

[GitHub] spark issue #14604: [Doc] add config option spark.ui.enabled into document

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14604 **[Test build #63615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63615/consoleFull)** for PR 14604 at commit

[GitHub] spark issue #14604: [Doc] add config option spark.ui.enabled into document

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14604 **[Test build #63615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63615/consoleFull)** for PR 14604 at commit

[GitHub] spark issue #14604: [Doc] add config option spark.ui.enabled into document

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14604 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63611/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/cache() s...

2016-08-11 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14579 @nchammas to be clear - subclassing only breaks pipelining if the persisted_rdd is later unpersisted (e.g. used with a `with` statement or otherwise) - otherwise you can't pipeline on top of a

[GitHub] spark issue #14598: [SPARK-17018][SQL] literals.sql for testing literal pars...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14598 This is pretty cool :) I am comparing this to the `ExpressionParserSuite`. Shouldn't we add support for more complex string cases, intervals and a type constructors, see:

[GitHub] spark pull request #14321: [SPARK-8971][ML] Add stratified sampling to ML Cr...

2016-08-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/14321#discussion_r74425472 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -662,6 +796,67 @@ class PairRDDFunctionsSuite extends SparkFunSuite

[GitHub] spark issue #14599: [SPARK-17013][SQL] handle corner case for negative integ...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14599 The `L`, `S` & `Y` suffixes come from Hive. The fix that is proposed by @petermaxlee has a potential problem when we try parse something like `a-1`. This will be tokenized into an

[GitHub] spark issue #14603: [SPARK-17021][SQL] simplify the constructor parameters o...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63609/ Test PASSed. ---

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63613/consoleFull)** for PR 14568 at commit

[GitHub] spark issue #14456: [SPARK-16831] [Python] Fixed bug in CrossValidator.avgMe...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14456 Oh dear. I give up on back-porting things to 1.6. It just breaks too much at this stage! I will revert. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #14598: [SPARK-17018][SQL] literals.sql for testing liter...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14598#discussion_r74426121 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -0,0 +1,148 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74434465 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +42,23 @@ import

  1   2   3   4   5   6   >