Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14926
Jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14926
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/14927
[SPARK-16922] [SPARK-17211] [SQL] make the address of values portable in
LongToUnsafeRowMap
## What changes were proposed in this pull request?
In LongToUnsafeRowMap, we use offset of a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14366
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14714
Hey @jianran,
Now that we have a JDBC data source in Spark SQL, I'd prefer to redirect
development effort there and not make any changes to the old `JdbcRDD`.
Therefore, would you mind
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #64806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64806/consoleFull)**
for PR 14077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64797/
Test PASSed.
---
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77261626
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {
val
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14613
**[Test build #64808 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64808/consoleFull)**
for PR 14613 at commit
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/14690
Thanks, that looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13979
**[Test build #64802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64802/consoleFull)**
for PR 13979 at commit
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/13584
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14366
**[Test build #64795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64795/consoleFull)**
for PR 14366 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14733#discussion_r77257908
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -125,12 +129,37 @@ case class
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14613#discussion_r77262914
--- Diff: R/pkg/R/types.R ---
@@ -67,3 +67,27 @@ rToSQLTypes <- as.environment(list(
"double" = "double",
"character" = "string",
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77265560
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -198,10 +219,12 @@ case class CreateViewCommand(
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14613
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64808/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14613
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14117
Thank you for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14613
**[Test build #64808 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64808/consoleFull)**
for PR 14613 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14923
**[Test build #64792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64792/consoleFull)**
for PR 14923 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14923
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14923
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64792/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14881
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14924
**[Test build #64798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64798/consoleFull)**
for PR 14924 at commit
Github user JustinPihony commented on a diff in the pull request:
https://github.com/apache/spark/pull/12601#discussion_r77239532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -114,7 +115,9 @@ private[sql] case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14925
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64799/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14925
**[Test build #64799 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64799/consoleFull)**
for PR 14925 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14925
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14925
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64796/consoleFull)**
for PR 14718 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14924
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14924
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64798/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14924
**[Test build #64798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64798/consoleFull)**
for PR 14924 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/14433#discussion_r77261262
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -135,7 +136,12 @@ private[spark] trait Logging {
val replLevel =
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14900
**[Test build #64807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64807/consoleFull)**
for PR 14900 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14897
Maybe we can create a few test cases for verifying the behaviors of global
temporary views. Below is an example. We did it for `current_database`
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/13979
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13979#discussion_r77250231
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
---
@@ -38,7 +38,10 @@ private[sql] case class
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/13979
LGTM given two minor nits and pending Jenkins. Let me retest this now and I
can just fix the `length` nit myself on merge.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64796/
Test FAILed.
---
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14733#discussion_r77257778
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -142,13 +171,16 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64797/consoleFull)**
for PR 14718 at commit
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14613#discussion_r77262850
--- Diff: R/pkg/R/types.R ---
@@ -67,3 +67,27 @@ rToSQLTypes <- as.environment(list(
"double" = "double",
"character" = "string",
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77263886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14733
I believe that the test failure is happening because
`InMemoryTableScanExec`'s `outputPartitioning` says that it has `n` partitions
yet the produced RDD may yield fewer than `n` partitions:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77265668
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {
val
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77265626
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {
val
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77265693
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -255,3 +287,43 @@ case class AlterViewAsCommand(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13979
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64802/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13979
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14926
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14926
**[Test build #64803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64803/consoleFull)**
for PR 14926 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davies commented on the issue:
https://github.com/apache/spark/pull/14515
LGTM, merging this into 2.0 and master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #64805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64805/consoleFull)**
for PR 14077 at commit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14733#discussion_r77259926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -98,9 +100,14 @@ case class InMemoryRelation(
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14433#discussion_r77260947
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -135,7 +136,12 @@ private[spark] trait Logging {
val replLevel
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14927#discussion_r77260990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -448,7 +448,7 @@ private[execution] final class
Github user sarutak commented on the issue:
https://github.com/apache/spark/pull/14900
@srowen Actually, I don't think that change is necessary because [an
existing
setting](https://github.com/apache/spark/pull/14900/files#diff-da6276fc4ab5cb98bed11c7259b60eaeR98)
encompasses that
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77264028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14117
Merged to master (2.1.0). Thanks @HyukjinKwon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13979#discussion_r77250039
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
---
@@ -38,7 +38,10 @@ private[sql] case class
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r77250600
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -90,6 +92,54 @@ package object config {
.toSequence
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13979
**[Test build #64802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64802/consoleFull)**
for PR 13979 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14866
**[Test build #64801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64801/consoleFull)**
for PR 14866 at commit
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77252890
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14925
Merging to master to fix the builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64795/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14117
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14117
**[Test build #64800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64800/consoleFull)**
for PR 14117 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14117
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64800/
Test PASSed.
---
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77264967
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -25,7 +25,41 @@ import
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14854#discussion_r77118807
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1331,6 +1335,103 @@ abstract class RDD[T: ClassTag](
}
}
+
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14854#discussion_r77118857
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -148,6 +148,12 @@ object SQLConf {
.booleanConf
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14912#discussion_r77122702
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
---
@@ -34,6 +34,7 @@ class FilterPushdownSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77122799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14659
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14659
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64757/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14659
**[Test build #64757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64757/consoleFull)**
for PR 14659 at commit
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/14914
[SPARK-17359][SQL][MLLib] Use ArrayBuffer.+=(A) instead of
ArrayBuffer.append(A) in performance critical paths
## What changes were proposed in this pull request?
We should generally use
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14892
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14914#discussion_r77130880
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -999,7 +999,7 @@ object Matrices {
val data = new
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14868
LGTM, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13584
**[Test build #64765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64765/consoleFull)**
for PR 13584 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14452#discussion_r77123756
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -89,6 +90,8 @@ abstract class Optimizer(sessionCatalog:
GitHub user watermen opened a pull request:
https://github.com/apache/spark/pull/14913
[SPARK-17358][SQL] Cached table(parquet/orc) should be shard between
beelines
## What changes were proposed in this pull request?
Cached table(parquet/orc) couldn't be shard between beelines,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14531
**[Test build #64763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64763/consoleFull)**
for PR 14531 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14531
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14515
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14515#discussion_r77136669
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -162,7 +162,13 @@ private[hive] case class MetastoreRelation(
Github user Stibbons commented on the issue:
https://github.com/apache/spark/pull/14863
I agree. I would prefer if Spark examples also "promotes" the good practice
of Python, ie, replacing 'map' and 'filter' by list or map comprehension
('reduce' has no equivalent on comprehension),
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/14864#discussion_r77118552
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -156,24 +156,56 @@ case class FileSourceScanExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77118535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog {
1 - 100 of 676 matches
Mail list logo
