Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user frreiss opened a pull request:
https://github.com/apache/spark/pull/15162
[SPARK-17386] [STREAMING] [WIP] Make polling rate adaptive
## What changes were proposed in this pull request?
This change makes the scheduler in `StreamExecution` adjust its rate of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14116
**[Test build #65664 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65664/consoleFull)**
for PR 14116 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15161
@tgravescs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13513
LGTM. Thanks! Merging to master and 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shubhamchopra commented on the issue:
https://github.com/apache/spark/pull/13152
Rebased to master to resolve merge conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14818
Thanks! I will update the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/15067#discussion_r79662093
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala
---
@@ -125,6 +125,32 @@ class StreamingQuerySuite extends
Github user frreiss closed the pull request at:
https://github.com/apache/spark/pull/15067
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14467#discussion_r79661108
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -866,11 +866,14 @@ class BytesToString extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14597
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65658/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14597
**[Test build #65658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65658/consoleFull)**
for PR 14597 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13680
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65657/
Test PASSed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14634
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13680
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13680
**[Test build #65657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65657/consoleFull)**
for PR 13680 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14634
LGTM. Merging to master and branch 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13822
does the problem still exist?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15158#discussion_r79656655
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -109,39 +109,59 @@ private[hive] case class MetastoreRelation(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15150
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15150
**[Test build #65661 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65661/consoleFull)**
for PR 15150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65661/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15157
**[Test build #65669 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65669/consoleFull)**
for PR 15157 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15157
I will merge this PR to master and branch 2.0 once it passes jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15157
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r79654723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -690,6 +690,7 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r79654687
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -33,134 +37,213 @@
// The
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15149
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65660/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15149
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15149
**[Test build #65660 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65660/consoleFull)**
for PR 15149 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r79653637
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -43,10 +43,11 @@
*
* In the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14897
**[Test build #65668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65668/consoleFull)**
for PR 14897 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Regenerate the answer set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14897
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14897
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65665/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14897
**[Test build #65665 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65665/consoleFull)**
for PR 14897 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14638
**[Test build #65666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65666/consoleFull)**
for PR 14638 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65667 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65667/consoleFull)**
for PR 14623 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15157
Oh, right. Will do that.
On Tue, Sep 20, 2016 at 8:57 AM -0700, "Marcelo Vanzin"
wrote:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14897
**[Test build #65665 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65665/consoleFull)**
for PR 14897 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15149
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15149
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65659/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15149
**[Test build #65659 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65659/consoleFull)**
for PR 15149 at commit
Github user frreiss commented on the issue:
https://github.com/apache/spark/pull/15005
I've about narrowed down the options that work for OpenJDK 7 and 8 on Mac
and Linux. Working on IBM Java on Linux. I can have an update in by EOD today.
BTW, one thing that's been slowing me
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14426
**[Test build #65663 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65663/consoleFull)**
for PR 14426 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14116
**[Test build #65664 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65664/consoleFull)**
for PR 14116 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14116
Rebased to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14959
Are these tests flaky or is the failure related to this change? (Other PRs
seem to be passing, so probably the latter?)
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14897
**[Test build #65662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65662/consoleFull)**
for PR 14897 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14897
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65662/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14897
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15157
If it's not too much trouble, keeping the workaround in CodeGenerator.scala
would be nice. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65652/
Test PASSed.
---
Github user Yunni commented on the issue:
https://github.com/apache/spark/pull/15148
Hi @sethah,
Thanks for the comments.
- I agree. I have moved `lsh` package to be under `feature`
- In "Similarity search in high dimensions via hashing", there is an
algorithm in the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15140
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14897
**[Test build #65662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65662/consoleFull)**
for PR 14897 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15140
**[Test build #65652 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65652/consoleFull)**
for PR 15140 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15149
Right now, that limit is only for parity with the randomForest package that
this is apparently based on. I agree that it's not clear why these couldn't sum
to something more than 1. If they were to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15150
**[Test build #65661 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65661/consoleFull)**
for PR 15150 at commit
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15149
+1 for not changing the sum requirement. I agree that we need to restrict
them to sum to something non-zero and all positive. Thanks for the
clarification.
---
If your project is set up for it,
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15150#discussion_r79641840
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -580,10 +581,14 @@ class Word2VecModel private[spark] (
ind +=
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15149
**[Test build #65660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65660/consoleFull)**
for PR 15149 at commit
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15149
Requiring these thresholds to sum <= 1 seems entirely arbitrary. I don't
know why thresholds that sum to `0.347` are any more valid than thresholds that
sum to `347`. If these are not meant to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15152
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15148#discussion_r79639164
--- Diff: mllib/src/main/scala/org/apache/spark/ml/lsh/LSH.scala ---
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65655/
Test FAILed.
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15150#discussion_r79638858
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -580,10 +581,14 @@ class Word2VecModel private[spark] (
ind +=
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15152
**[Test build #65655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65655/consoleFull)**
for PR 15152 at commit
Github user yaooqinn commented on a diff in the pull request:
https://github.com/apache/spark/pull/15071#discussion_r79637407
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BroadcastHashJoinBenchmark.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15150#discussion_r79637489
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -580,10 +581,14 @@ class Word2VecModel private[spark] (
ind +=
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/14808
I think we should add an example for multiclass classification, to
demonstrate that it works in 2.1+. We also need to update the documentation
that says we only support binary.
---
If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79635467
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15149
**[Test build #65659 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65659/consoleFull)**
for PR 15149 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79635015
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12819#discussion_r79632172
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -150,6 +150,75 @@ class NaiveBayesSuite extends SparkFunSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15160
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65654/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15160
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15160
**[Test build #65654 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65654/consoleFull)**
for PR 15160 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79631445
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79630399
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14597
**[Test build #65658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65658/consoleFull)**
for PR 14597 at commit
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/14597
No problem. thanks very much @srowen .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/15102
You should not be assuming 0 for a starting offset for partitions you've
just learned about. You should be asking the underlying driver consumer what
its position is. This is yet another
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13680
**[Test build #65657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65657/consoleFull)**
for PR 13680 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79628242
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65656/
Test PASSed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15054
It should be not hard. Will make a try today to backport to 2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65656/consoleFull)**
for PR 15139 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13680
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13680
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65651/
Test PASSed.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15143
This is to some degree covered by other tests, yes. It's probably just not
worth 100 lines of test code to test the contents of a Set from all angles.
I think the other two non-test changes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13680
**[Test build #65651 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65651/consoleFull)**
for PR 13680 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15131
@shivaram @felixcheung @HyukjinKwon Any thoughts? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15005
@frreiss are you in a position to finish this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15139#discussion_r79614619
--- Diff: R/pkg/R/mllib.R ---
@@ -1398,20 +1398,22 @@ setMethod("summary", signature(object = "KSTest"),
distParams <-
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r79614500
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -199,6 +200,7 @@ public void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r79614390
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala
---
@@ -141,12 +141,18 @@ class UnsafeArraySuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r79614191
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java
---
@@ -67,9 +67,9 @@ public UnsafeMapData() {
301 - 400 of 572 matches
Mail list logo