[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15541 **[Test build #67395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67395/consoleFull)** for PR 15541 at commit

[GitHub] spark issue #15377: [SPARK-17802] Improved caller context logging.

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15377 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67394/ Test FAILed. ---

[GitHub] spark issue #15377: [SPARK-17802] Improved caller context logging.

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15377 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15377: [SPARK-17802] Improved caller context logging.

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15377 **[Test build #67394 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67394/consoleFull)** for PR 15377 at commit

[GitHub] spark issue #14788: [SPARK-17174][SQL] Add the support for TimestampType for...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14788 It would work with different names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15575: [SPARK-18038] [SQL] Move output partitioning definition ...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15575 @tejasapatil you were linking to a fb internal branch :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15575: [SPARK-18038] [SQL] Move output partitioning definition ...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15575 CoalesceExec is not SinglePartition. Coalesce can lead to an arbitrary number of partitions. ExpandExec doesn't really change the partitioning either. --- If your project is set up for it,

[GitHub] spark issue #15484: [SPARK-17868][SQL] Do not use bitmasks during parsing an...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15484 cc @davies too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #15484: [SPARK-17868][SQL] Do not use bitmasks during par...

2016-10-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15484#discussion_r84583794 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -255,98 +265,125 @@ class Analyzer( expr

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84583708 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala --- @@ -43,11 +43,20 @@ import

[GitHub] spark pull request #12913: [SPARK-928][CORE] Add support for Unsafe-based se...

2016-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12913 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #12913: [SPARK-928][CORE] Add support for Unsafe-based serialize...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/12913 Merging in master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15587: [SPARK-18051][Spark Core] fix bug of custom Parti...

2016-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15580: [SPARK-18042][SQL] OutputWriter should expose file path ...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15580 @HyukjinKwon sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14529 OK I will include this in my next pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15587: [SPARK-18051][Spark Core] fix bug of custom PartitionCoa...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15587 Merging in master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14788: [SPARK-17174][SQL] Add the support for TimestampType for...

2016-10-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14788 Does option 1 really work? Wouldn't the expressions have the same user facing function names? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIKE' patt...

2016-10-22 Thread jodersky
Github user jodersky commented on the issue: https://github.com/apache/spark/pull/15398 @gatorsmile thx for the review. I'll update the test suite as we discussed initially :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIK...

2016-10-22 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/15398#discussion_r84582746 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -68,7 +68,20 @@ trait StringRegexExpression

[GitHub] spark pull request #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in...

2016-10-22 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/15441#discussion_r84582699 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala --- @@ -35,4 +37,20 @@ private[ui] class JobsTab(parent: SparkUI) extends

[GitHub] spark pull request #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIK...

2016-10-22 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/15398#discussion_r84582662 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala --- @@ -19,32 +19,34 @@ package

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-22 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15553 @srowen -Dmaven.test.skip=true is the documented way in maven to skip test compilation (http://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-test.html) which we are not

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67393/ Test PASSed. ---

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67393/consoleFull)** for PR 15072 at commit

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread jodersky
Github user jodersky commented on the issue: https://github.com/apache/spark/pull/15513 I agree with that the extended part is usually multiple lines, my observation is that an newline will be inserted *before* any text, since the string starts the line following `extended="""`. Just

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84582345 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -125,7 +129,7 @@ case class DescribeFunctionCommand(

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 Oh, yes. I thought a newline for multiple lines looks nicer (and also assumed extended part is always multiple lines). Please refer the PR description. Also, actually, I tries

[GitHub] spark issue #15377: [SPARK-17802] Improved caller context logging.

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15377 **[Test build #67394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67394/consoleFull)** for PR 15377 at commit

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 I definitely will tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread jodersky
Github user jodersky commented on the issue: https://github.com/apache/spark/pull/15513 More documentation is always great, thanks! Are the newlines at the beginning of each expression intentional? E.g. ``` extended = """ Arguments: class - a string literal

[GitHub] spark pull request #15072: [SPARK-17123][SQL] Use type-widened encoder for D...

2016-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15072 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 @HyukjinKwon I cannot cherry-pick this into 2.0. Can you open a PR against 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 Merging to master and 2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67392/ Test PASSed. ---

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15072 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67392/consoleFull)** for PR 15072 at commit

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13988 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 (@hvanhovell Thank you for reviewing closly) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13988 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67391/ Test PASSed. ---

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13988 **[Test build #67391 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67391/consoleFull)** for PR 13988 at commit

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 LGTM - pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67393/consoleFull)** for PR 15072 at commit

[GitHub] spark issue #15587: [SPARK-18051][Spark Core] fix bug of custom PartitionCoa...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15587 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67388/ Test PASSed. ---

[GitHub] spark issue #15587: [SPARK-18051][Spark Core] fix bug of custom PartitionCoa...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15587 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15587: [SPARK-18051][Spark Core] fix bug of custom PartitionCoa...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15587 **[Test build #67388 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67388/consoleFull)** for PR 15587 at commit

[GitHub] spark pull request #15072: [SPARK-17123][SQL] Use type-widened encoder for D...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15072#discussion_r84580480 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2725,4 +2725,14 @@ class Dataset[T] private[sql]( @inline private def

[GitHub] spark issue #15354: [SPARK-17764][SQL] Add `to_json` supporting to convert n...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15354 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67387/ Test PASSed. ---

[GitHub] spark issue #15354: [SPARK-17764][SQL] Add `to_json` supporting to convert n...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15354 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15354: [SPARK-17764][SQL] Add `to_json` supporting to convert n...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15354 **[Test build #67387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67387/consoleFull)** for PR 15354 at commit

[GitHub] spark issue #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIKE' patt...

2016-10-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15398 @jodersky Sorry. I misunderstood your point in the offline discussion. After reading the codes, I think your original proposal is right. This PR needs to clean up the test suite `LIKE literal

[GitHub] spark issue #15599: [SPARK-18022][SQL] java.lang.NullPointerException instea...

2016-10-22 Thread maver1ck
Github user maver1ck commented on the issue: https://github.com/apache/spark/pull/15599 I can try this fix on Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14529 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14529 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67390/ Test PASSed. ---

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14529 **[Test build #67390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67390/consoleFull)** for PR 14529 at commit

[GitHub] spark pull request #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIK...

2016-10-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15398#discussion_r84579527 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala --- @@ -53,6 +57,40 @@ class

[GitHub] spark issue #15566: [SPARK-18026][SQL] should not always lowercase partition...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15566 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15566: [SPARK-18026][SQL] should not always lowercase partition...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15566 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67389/ Test FAILed. ---

[GitHub] spark issue #15566: [SPARK-18026][SQL] should not always lowercase partition...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15566 **[Test build #67389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67389/consoleFull)** for PR 15566 at commit

[GitHub] spark pull request #15072: [SPARK-17123][SQL] Use type-widened encoder for D...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15072#discussion_r84579406 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2725,4 +2725,14 @@ class Dataset[T] private[sql]( @inline private def

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15072 **[Test build #67392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67392/consoleFull)** for PR 15072 at commit

[GitHub] spark issue #15428: [SPARK-17219][ML] enhanced NaN value handling in Bucketi...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67386/ Test PASSed. ---

[GitHub] spark issue #15428: [SPARK-17219][ML] enhanced NaN value handling in Bucketi...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15428: [SPARK-17219][ML] enhanced NaN value handling in Bucketi...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15428 **[Test build #67386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67386/consoleFull)** for PR 15428 at commit

[GitHub] spark pull request #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15596#discussion_r84579127 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala --- @@ -36,14 +36,14 @@ import org.apache.spark.util.Utils case class

[GitHub] spark issue #15590: [SPARK-17949][SQL] A JVM object based aggregate operator

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15590 This is pretty cool. I was wondering how much code this shares with the regular hash based aggregation path? And if it is worth the effort to integrate the two paths? We can do this in

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 @hvanhovell Oh, that looks cleaner and nicer. I will try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15595 +1 on adding a test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15072 @HyukjinKwon can we move this into a set specific method within Dataset itself, for example: ```scala /** A convenient function to wrap a set based logical plan and produce a Dataset. */

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67385/ Test PASSed. ---

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15591: [SPARK-17922] [SQL] ClassCastException java.lang....

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15591#discussion_r84578800 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -615,11 +616,8 @@ class

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15513 **[Test build #67385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67385/consoleFull)** for PR 15513 at commit

[GitHub] spark issue #15591: [SPARK-17922] [SQL] ClassCastException java.lang.ClassCa...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15591 @AbhiMadav I think we need a test to confirm this PR fixes that problem and avoid the regression in the future. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13988 **[Test build #67391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67391/consoleFull)** for PR 13988 at commit

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15595 @CodingCat I think we need a test maybe (at least the one specified in the JIRA) to confirm this PR fixes that problem and avoid the regression in the future. --- If your project is set up

[GitHub] spark pull request #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIK...

2016-10-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15398#discussion_r84578560 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala --- @@ -19,32 +19,34 @@ package

[GitHub] spark issue #15599: [SPARK-18022][SQL] java.lang.NullPointerException instea...

2016-10-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15599 If we do not have a test case, could you post the exception before the fix and the exception output after the fix? Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14529 **[Test build #67390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67390/consoleFull)** for PR 14529 at commit

[GitHub] spark issue #14788: [SPARK-17174][SQL] Add the support for TimestampType for...

2016-10-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14788 I prefer option 1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15566: [SPARK-18026][SQL] should not always lowercase partition...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15566 **[Test build #67389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67389/consoleFull)** for PR 15566 at commit

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67384/ Test FAILed. ---

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15513 **[Test build #67384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67384/consoleFull)** for PR 15513 at commit

[GitHub] spark issue #15566: [SPARK-18026][SQL] should not always lowercase partition...

2016-10-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15566 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15587: [SPARK-18051][Spark Core] fix bug of custom PartitionCoa...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15587 **[Test build #67388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67388/consoleFull)** for PR 15587 at commit

[GitHub] spark issue #15566: [SPARK-18026][SQL] should not always lowercase partition...

2016-10-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15566 I have changed it to `This PR makes partition spec case preserving at parser`, sorry for the confusion. Previously we were lazy and alway lower case the column names in partition spec.

[GitHub] spark issue #15580: [SPARK-18042][SQL] OutputWriter should expose file path ...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15580 @rxin BTW, could I please ask to include https://github.com/apache/spark/pull/14529 in your future related PRs? I will close if you will. --- If your project is set up for it, you can reply

[GitHub] spark issue #15587: [SPARK-18051][Spark Core] fix bug of custom PartitionCoa...

2016-10-22 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15587 @rxin Good suggestion. code & document updated, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15361: [SPARK-17765][SQL] Support for writing out user-defined ...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15361 @chenghao-intel @davies Would there be other things maybe I should test or take care of? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #15072: [SPARK-17123][SQL] Use type-widened encoder for DataFram...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15072 @liancheng @hvanhovell @davies @cloud-fan Would there be other things maybe I should take care of ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #15049: [SPARK-17310][SQL] Add an option to disable record-level...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15049 gentle ping @davies @liancheng @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14788: [SPARK-17174][SQL] Add the support for TimestampType for...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14788 @rxin @hvanhovell @cloud-fan Could I please ask the behaviour we want here? 1. Separate expressions for both `DateType` and `TimestampType` 2. Returns `DateType` for `DateType` and

[GitHub] spark issue #14660: [SPARK-17071][SQL] Add an option to support for reading ...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14660 Could you please take a look please @rxin and @liancheng? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14627 @liancheng If you are uncertain of `OrcFileOperator.scala` I will definitely remove this in this PR. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13771: [SPARK-13748][PYSPARK][DOC] Add the description for expl...

2016-10-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13771 gentle ping @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15517: [SPARK-17972][SQL] Build Datasets upon `withCachedData` ...

2016-10-22 Thread naliazheli
Github user naliazheli commented on the issue: https://github.com/apache/spark/pull/15517 dataset.checkpoint is what i need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15539: [SPARK-17994] [SQL] Add back a file status cache ...

2016-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15539: [SPARK-17994] [SQL] Add back a file status cache for cat...

2016-10-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15539 merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15354: [SPARK-17764][SQL] Add `to_json` supporting to convert n...

2016-10-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15354 **[Test build #67387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67387/consoleFull)** for PR 15354 at commit

<    1   2   3   >