[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15994 **[Test build #69238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69238/consoleFull)** for PR 15994 at commit

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69238/ Test PASSed. ---

[GitHub] spark issue #16032: [SPARK-18118][SQL] fix a compilation error due to nested...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16032 **[Test build #69240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69240/consoleFull)** for PR 16032 at commit

[GitHub] spark issue #16032: [SPARK-18118][SQL] fix a compilation error due to nested...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16032 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69240/ Test PASSed. ---

[GitHub] spark issue #16032: [SPARK-18118][SQL] fix a compilation error due to nested...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16032 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16035: [SQL][minor] DESC should use 'Catalog' as partiti...

2016-11-28 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16035 [SQL][minor] DESC should use 'Catalog' as partition provider ## What changes were proposed in this pull request? `CatalogTable` has a parameter named `tracksPartitionsInCatalog`, and in

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13557 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13557 **[Test build #69245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69245/consoleFull)** for PR 13557 at commit

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13557 **[Test build #69246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69246/consoleFull)** for PR 13557 at commit

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69236/ Test PASSed. ---

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15994 **[Test build #69236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69236/consoleFull)** for PR 15994 at commit

[GitHub] spark issue #16011: [SPARK-18587][ML] Remove handleInvalid from QuantileDisc...

2016-11-28 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16011 When I did QA work for 2.1, I found the parameter ``` handleInvalid``` is disorienting. For example, the default behavior of ```QuantileDiscretizer``` to handle invalid value (i.e. NaN) is

[GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...

2016-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89770609 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2061,9 +2061,8 @@ class SparkContext(config: SparkConf) extends Logging { *

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do not push-down join conditions to t...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16026 **[Test build #69242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69242/consoleFull)** for PR 16026 at commit

[GitHub] spark issue #16034: [SPARK-18527][SQL] Convert decimal array to double array...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16034 **[Test build #69243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69243/consoleFull)** for PR 16034 at commit

[GitHub] spark pull request #16032: [SPARK-18118][SQL] fix a compilation error due to...

2016-11-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16032#discussion_r89771857 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -896,19 +896,25 @@ case class

[GitHub] spark pull request #16033: SPARK-18607 get a result on a percent of the task...

2016-11-28 Thread Ru-Xiang
Github user Ru-Xiang commented on a diff in the pull request: https://github.com/apache/spark/pull/16033#discussion_r89775912 --- Diff: core/src/main/scala/org/apache/spark/partial/ApproximateActionListener.scala --- @@ -34,11 +34,13 @@ private[spark] class

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15780 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69235/ Test PASSed. ---

[GitHub] spark pull request #16033: SPARK-18607 get a result on a percent of the task...

2016-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16033#discussion_r89769503 --- Diff: core/src/main/scala/org/apache/spark/partial/ApproximateActionListener.scala --- @@ -34,11 +34,13 @@ private[spark] class

[GitHub] spark pull request #16032: [SPARK-18118][SQL] fix a compilation error due to...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16032#discussion_r89772748 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -896,19 +896,25 @@ case class

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13557 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69245/ Test FAILed. ---

[GitHub] spark pull request #16020: [SPARK-18596][ML] add checking and caching to bis...

2016-11-28 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/16020#discussion_r89780207 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -255,10 +256,19 @@ class BisectingKMeans @Since("2.0.0") (

[GitHub] spark issue #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16036 cc @hvanhovell @dongjoon-hyun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTIT...

2016-11-28 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16036 [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION should support comparators ## What changes were proposed in this pull request? https://github.com/apache/spark/pull/15704 will fail

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13557 **[Test build #69246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69246/consoleFull)** for PR 13557 at commit

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13557 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15991: [SPARK-17843][WEB UI] Indicate event logs pending...

2016-11-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/15991#discussion_r89786503 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala --- @@ -33,21 +33,40 @@ private[history] class HistoryPage(parent:

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69237/ Test PASSed. ---

[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16031 **[Test build #69239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69239/consoleFull)** for PR 16031 at commit

[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16031 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16032: [SPARK-18118][SQL] fix a compilation error due to...

2016-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16032 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69241/ Test PASSed. ---

[GitHub] spark pull request #16024: [MINOR][DOCS] Updates to the Accumulator example ...

2016-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16024#discussion_r89771582 --- Diff: docs/programming-guide.md --- @@ -1378,29 +1378,36 @@ res2: Long = 10 While this code used the built-in support for accumulators of type

[GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...

2016-11-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89772073 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2061,9 +2061,8 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16013 Thank you so much @srowen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15994 **[Test build #69237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69237/consoleFull)** for PR 15994 at commit

[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69239/ Test PASSed. ---

[GitHub] spark issue #16032: [SPARK-18118][SQL] fix a compilation error due to nested...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16032 LGTM - merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss ...

2016-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15994#discussion_r89772926 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -145,6 +151,14 @@ final class DataFrameNaFunctions private[sql](df:

[GitHub] spark pull request #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss ...

2016-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15994#discussion_r89772231 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -437,4 +438,38 @@ final class DataFrameNaFunctions private[sql](df:

[GitHub] spark issue #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16036 **[Test build #69248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69248/consoleFull)** for PR 16036 at commit

[GitHub] spark pull request #15594: [SPARK-18061][SQL][Security] Spark Thriftserver n...

2016-11-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/15594#discussion_r89787175 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala --- @@ -57,7 +59,24 @@ private[hive]

[GitHub] spark pull request #16034: [SPARK-18527][SQL] Convert decimal array to doubl...

2016-11-28 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/16034 [SPARK-18527][SQL] Convert decimal array to double array double for Hive UDAFPercentile ## What changes were proposed in this pull request? (Please fill in changes proposed in this

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69241/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16035: [SQL][minor] DESC should use 'Catalog' as partition prov...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16035 **[Test build #69244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69244/consoleFull)** for PR 16035 at commit

[GitHub] spark issue #16035: [SQL][minor] DESC should use 'Catalog' as partition prov...

2016-11-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16035 cc @ericl @yhuai @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13557 **[Test build #69245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69245/consoleFull)** for PR 13557 at commit

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16020 **[Test build #69247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69247/consoleFull)** for PR 16020 at commit

[GitHub] spark issue #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KMeans of...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13557 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69246/ Test PASSed. ---

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15994 **[Test build #69249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69249/consoleFull)** for PR 15994 at commit

[GitHub] spark pull request #16024: [MINOR][DOCS] Updates to the Accumulator example ...

2016-11-28 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/16024#discussion_r89791975 --- Diff: docs/programming-guide.md --- @@ -1378,29 +1378,36 @@ res2: Long = 10 While this code used the built-in support for accumulators of

[GitHub] spark issue #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16036 LGTM pending jenkins. @dongjoon-hyun lets merge the implementation of `ALTER TABLE DROP PARTITION` with your fix for it in https://github.com/apache/spark/pull/15987. --- If your

[GitHub] spark pull request #15958: [SPARK-17932][SQL] Support SHOW TABLES EXTENDED L...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15958#discussion_r89794720 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -589,30 +589,49 @@ case class DescribeTableCommand( *

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do not push-down join conditions to t...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16026 **[Test build #69242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69242/consoleFull)** for PR 16026 at commit

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-11-28 Thread AnthonyTruchet
GitHub user AnthonyTruchet opened a pull request: https://github.com/apache/spark/pull/16037 [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vectors of 0 ## What changes were proposed in this pull request? CostFun used to send a dense vector of zeroes as a closure in a

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16020 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69247/ Test PASSed. ---

[GitHub] spark issue #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE and DESC ...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15358 @gatorsmile I cannot merge this into branch 2.0. Could you open a PR if you feel that we should have this in 2.0? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #15480: [SPARK-16845][SQL] `GeneratedClass$SpecificOrderi...

2016-11-28 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15480#discussion_r89802303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -118,7 +118,42 @@ object

[GitHub] spark issue #16035: [SQL][minor] DESC should use 'Catalog' as partition prov...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16035 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16020 **[Test build #69247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69247/consoleFull)** for PR 16020 at commit

[GitHub] spark issue #13988: [SPARK-16101][SQL] Refactoring CSV data source to be con...

2016-11-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13988 I will try to split this into two PRs for read path and write path. Would that sound okay to you both @rxin and @hvanhovell? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16034: [SPARK-18527][SQL] Convert decimal array to double array...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16034 **[Test build #69243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69243/consoleFull)** for PR 16034 at commit

[GitHub] spark pull request #15963: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-11-28 Thread AnthonyTruchet
Github user AnthonyTruchet closed the pull request at: https://github.com/apache/spark/pull/15963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #16024: [MINOR][DOCS] Updates to the Accumulator example ...

2016-11-28 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/16024#discussion_r89788527 --- Diff: docs/programming-guide.md --- @@ -1424,29 +1431,38 @@ accum.value(); // returns 10 {% endhighlight %} -Programmers can also

[GitHub] spark pull request #15480: [SPARK-16845][SQL] `GeneratedClass$SpecificOrderi...

2016-11-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15480#discussion_r89789490 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -118,7 +118,42 @@ object

[GitHub] spark issue #16025: [SPARK-18602] Set the version of org.codehaus.janino:com...

2016-11-28 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/16025 LGTM, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16020 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE an...

2016-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do not push-down join conditions to t...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69242/ Test PASSed. ---

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do not push-down join conditions to t...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16026 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16034: [SPARK-18527][SQL] Convert decimal array to double array...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16034 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16034: [SPARK-18527][SQL] Convert decimal array to double array...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69243/ Test PASSed. ---

[GitHub] spark issue #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16036 I see. @cloud-fan and @hvanhovell . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15963: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-28 Thread AnthonyTruchet
Github user AnthonyTruchet commented on the issue: https://github.com/apache/spark/pull/15963 Once more (last time hopefully) I mistakenly fiddled with PR. Closing this one and replace it with #16037. Code style review above taken into account in new PR. --- If your project is

[GitHub] spark pull request #16024: [MINOR][DOCS] Updates to the Accumulator example ...

2016-11-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16024#discussion_r89795879 --- Diff: docs/programming-guide.md --- @@ -1378,29 +1378,36 @@ res2: Long = 10 While this code used the built-in support for accumulators of type

[GitHub] spark issue #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE and DESC ...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15358 LGTM. Merging to master/2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do not push-down join conditions to t...

2016-11-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16026 I am merging this to master/2.1. Thanks for the reviews! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #16026: [SPARK-18597][SQL] Do not push-down join conditio...

2016-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16026 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16035: [SQL][minor] DESC should use 'Catalog' as partition prov...

2016-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16035 **[Test build #69244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69244/consoleFull)** for PR 16035 at commit

[GitHub] spark pull request #16017: [SPARK-18592][ML] Move DT/RF/GBT Param setter met...

2016-11-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16017#discussion_r89806761 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -52,33 +52,49 @@ class DecisionTreeClassifier

[GitHub] spark issue #16035: [SQL][minor] DESC should use 'Catalog' as partition prov...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16035 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69244/ Test PASSed. ---

[GitHub] spark issue #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16037 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16038: [SPARK-18471][CORE] New treeAggregate overload for big l...

2016-11-28 Thread AnthonyTruchet
Github user AnthonyTruchet commented on the issue: https://github.com/apache/spark/pull/16038 @srowen here is the companion PR to #16037. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16039: [SPARK-18597][SQL] Do not push-down join conditio...

2016-11-28 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/16039 [SPARK-18597][SQL] Do not push-down join conditions to the left side of a Left Anti join [BRANCH-2.0] ## What changes were proposed in this pull request? We currently push down join

[GitHub] spark issue #16038: [SPARK-18471][CORE] New treeAggregate overload for big l...

2016-11-28 Thread AnthonyTruchet
Github user AnthonyTruchet commented on the issue: https://github.com/apache/spark/pull/16038 It is related as if this PR get accepted, then the fix for PR to #16037 becomes trivial: replace treeAggregate with a call to `treeAggregateWithZeroGenerator( () => (Vectors.zeros(n),

[GitHub] spark pull request #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KM...

2016-11-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13557#discussion_r89817603 --- Diff: python/pyspark/ml/clustering.py --- @@ -330,6 +357,20 @@ class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol

[GitHub] spark pull request #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KM...

2016-11-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13557#discussion_r89817165 --- Diff: python/pyspark/ml/clustering.py --- @@ -330,6 +357,20 @@ class KMeans(JavaEstimator, HasFeaturesCol, HasPredictionCol, HasMaxIter, HasTol

[GitHub] spark pull request #16040: [SPARK-18612][MLLIB] Delete broadcasted variable ...

2016-11-28 Thread AnthonyTruchet
GitHub user AnthonyTruchet opened a pull request: https://github.com/apache/spark/pull/16040 [SPARK-18612][MLLIB] Delete broadcasted variable in LBFGS CostFun ## What changes were proposed in this pull request? Fix a broadcasted variable leak occurring at each invocation of

[GitHub] spark pull request #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KM...

2016-11-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13557#discussion_r89816135 --- Diff: python/pyspark/ml/clustering.py --- @@ -201,7 +202,74 @@ def computeCost(self, dataset): """ return

[GitHub] spark pull request #13557: [SPARK-15819][PYSPARK][ML] Add KMeanSummary in KM...

2016-11-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13557#discussion_r89817695 --- Diff: python/pyspark/ml/clustering.py --- @@ -316,7 +318,32 @@ def computeCost(self, dataset): """ return

[GitHub] spark pull request #16017: [SPARK-18592][ML] Move DT/RF/GBT Param setter met...

2016-11-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16017#discussion_r89819028 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -134,27 +150,31 @@ private[ml] trait DecisionTreeParams extends

[GitHub] spark issue #16040: [SPARK-18612][MLLIB] Delete broadcasted variable in LBFG...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16040 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16038: [SPARK-18471][CORE] New treeAggregate overload fo...

2016-11-28 Thread AnthonyTruchet
GitHub user AnthonyTruchet opened a pull request: https://github.com/apache/spark/pull/16038 [SPARK-18471][CORE] New treeAggregate overload for big large aggregators ## What changes were proposed in this pull request? The zero for the aggregation used to be shipped into a

[GitHub] spark issue #16038: [SPARK-18471][CORE] New treeAggregate overload for big l...

2016-11-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16038 This is not really related to the other change or the JIRA though. It also doesn't seem to address the problem as you describe it elsewhere. It's not that the zero value is big (a sparse 0 vector

[GitHub] spark issue #16038: [SPARK-18471][CORE] New treeAggregate overload for big l...

2016-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16038 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16037 OK, this is the fourth pull request though (not counting a not-quite-related 5th). You don't need to open a new PR to push more changes and it adds to the difficulty in reviewing. This still doesn't

  1   2   3   4   5   6   7   >