Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16269#discussion_r99401502
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -80,13 +80,17 @@ class DetermineHiveSerde(conf: SQLConf) extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16269#discussion_r99401545
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -45,7 +45,8 @@ import
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
Great, @liancheng .
BTW, could you specify the test dependency like the following in this PR?
```
diff --git a/sql/core/pom.xml b/sql/core/pom.xml
index b8aa698090..f9acf815e3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16791
**[Test build #72315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72315/testReport)**
for PR 16791 at commit
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
I see, thanks for the context. But I'd like to keep this Maven build
failure fix in a separate PR so that people can easily cherry-pick the fix.
Also, it helps to keep this PR easier to follow.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16784
**[Test build #72312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72312/testReport)**
for PR 16784 at commit
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
Hope we finally have proper Parquet filter push-down for string/binary
columns (cross fingers)!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
Here,
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7/2530/consoleFull
```
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/16686#discussion_r99382639
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaTopicPartitionOffsetReader.scala
---
@@ -0,0 +1,300 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72309/
Test FAILed.
---
Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99386276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -190,6 +192,32 @@ final class DataFrameWriter[T] private[sql](ds:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16757#discussion_r99390416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -154,56 +155,108 @@ class SimpleTestOptimizer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16269#discussion_r99390405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -376,28 +376,6 @@ trait CheckAnalysis extends
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/16784
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16269
LGTM except a few comment. The major concern is about our error checking
for structured streaming. It sounds like the test case coverage in that area is
weak.
---
If your project is set up for
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
@dongjoon-hyun Ah, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13712#discussion_r99450752
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -271,6 +271,33 @@ private[spark] class Client(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16786
Could you rename `findTightestCommonTypeOfTwo` to `findTightestCommonType`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16794
Not sure why the unit test on kmeans summary failed since nothing was
changed there. Also, all unit tests passed on my computer.
---
If your project is set up for it, you can reply to this
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r99440166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -80,18 +80,16 @@ final class DataFrameStatFunctions
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16794
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16795
**[Test build #72322 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72322/testReport)**
for PR 16795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16794
**[Test build #72330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72330/testReport)**
for PR 16794 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16533
**[Test build #72331 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72331/testReport)**
for PR 16533 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16783
**[Test build #72324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72324/testReport)**
for PR 16783 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16786
**[Test build #72332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72332/testReport)**
for PR 16786 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16794
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72330/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16794
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72326/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16797
**[Test build #72326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72326/testReport)**
for PR 16797 at commit
GitHub user nsyca opened a pull request:
https://github.com/apache/spark/pull/16798
[SPARK-18873][SQL][TEST] New test cases for scalar subquery (part 2 of 2) -
scalar subquery in predicate context
## What changes were proposed in this pull request?
This PR adds new test cases
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16794
@felixcheung @wangmiao1981
I spent quite some time on this b/c I could not replicate the results and
all tests on my end worked.
Then I updated my local spark with a pull request and
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16799
Errors can be seen in #16794.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16791
BTW, LGTM for the changes in `ParquetSchrmaConverter` as i have the exact
same changes ready for a PR in my local. However, do you mind if I ask
PARQUET-686 is fixed in another JIRA? it seems
Github user nsyca commented on the issue:
https://github.com/apache/spark/pull/16798
Below are a modified version of the test cases to run on DB2 and the result
from DB2, as a second source to compare to the result from Spark.
[Modified test file to run on
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16786
Also clean up the comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/16794
Warning in FUN(X[[1L]], ...) :
Use Sepal_Length instead of Sepal.Length as column name
Warning in FUN(X[[2L]], ...) :
Use Sepal_Width instead of Sepal.Width as column name
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/16794
try {r, warning=FALSE} for the warning cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16664
**[Test build #72329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72329/testReport)**
for PR 16664 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16794
**[Test build #72327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72327/testReport)**
for PR 16794 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16794
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72327/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16794
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16794
**[Test build #72330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72330/testReport)**
for PR 16794 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16800
**[Test build #72339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72339/testReport)**
for PR 16800 at commit
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/16156
https://issues.apache.org/jira/browse/SPARK-19409 is resolved to upgrade to
parquet-1.8.2 that fixes this issue.
---
If your project is set up for it, you can reply to this email and have your
Github user xwu0226 closed the pull request at:
https://github.com/apache/spark/pull/16156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16726
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16794
**[Test build #72327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72327/testReport)**
for PR 16794 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16533
**[Test build #72328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72328/testReport)**
for PR 16533 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16776
Thank you! What is the expected output if the input dataset is empty? Could
you also add a test case?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16795
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16533
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72328/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72322/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16533
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16533
**[Test build #72328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72328/testReport)**
for PR 16533 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16533
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72331/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16686
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72333/
Test PASSed.
---
Github user budde commented on the issue:
https://github.com/apache/spark/pull/16797
Relevant part of [Jenkins
output](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72326/console)
for SparkR tests:
```
Error: processing vignette
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/16799
[SparkR] fix error in vignettes
## What changes were proposed in this pull request?
Current version has error in vignettes:
```
model <- spark.bisectingKmeans(df, Sepal_Length
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16794
good catch, seems reasonable (although might be a small breaking behavior
change)
Error in tests is with doc generation:
```
Error: processing vignette 'sparkr-vignettes.Rmd'
Github user budde commented on the issue:
https://github.com/apache/spark/pull/16797
Pinging @ericl, @cloud-fan and @davies, committers who have all reviewed or
submitted changes related to this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16797
**[Test build #72326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72326/testReport)**
for PR 16797 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16757
**[Test build #72323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72323/testReport)**
for PR 16757 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16686
**[Test build #72333 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72333/testReport)**
for PR 16686 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16796
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16796
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72325/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16796
**[Test build #72325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72325/testReport)**
for PR 16796 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16795
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72329/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16786#discussion_r99453060
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala
---
@@ -253,7 +253,7 @@ private[sql] object
Github user budde commented on the issue:
https://github.com/apache/spark/pull/16797
Looks like SparkR unit tests have been failing for all or most PRs after
[this
commit.](https://github.com/apache/spark/commit/48aafeda7db879491ed36fff89d59ca7ec3136fa)
---
If your project is set
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16798
**[Test build #72337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72337/testReport)**
for PR 16798 at commit
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/16800
[SPARK-19456][SparkR][WIP]:Add LinearSVC R API
## What changes were proposed in this pull request?
Linear SVM classifier is newly added into ML and python API has been added.
This
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16626
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16626
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72320/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16626
**[Test build #72320 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72320/testReport)**
for PR 16626 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72323/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16757
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16783
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16783
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72324/
Test FAILed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16786
Thanks, I just updated and rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16533
**[Test build #72331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72331/testReport)**
for PR 16533 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16533
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16795
**[Test build #72334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72334/testReport)**
for PR 16795 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/16794
still document failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/16794
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16664
**[Test build #72329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72329/testReport)**
for PR 16664 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16794
**[Test build #72335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72335/testReport)**
for PR 16794 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16783
**[Test build #72336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72336/testReport)**
for PR 16783 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16799
**[Test build #72338 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72338/testReport)**
for PR 16799 at commit
GitHub user budde opened a pull request:
https://github.com/apache/spark/pull/16797
[SPARK-19455][SQL] Add option for case-insensitive Parquet field resolution
## What changes were proposed in this pull request?
**Summary**
- Add
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16533
@holdenk If believe this is a good as it gets at this moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16686
**[Test build #72333 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72333/testReport)**
for PR 16686 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16686
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16783
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99453218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +465,10 @@ final class DataFrameWriter[T] private[sql](ds:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99453252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +246,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16798#discussion_r99453763
--- Diff: sql/core/src/test/resources/sql-tests/inputs/scalar-subquery.sql
---
@@ -1,20 +0,0 @@
-CREATE OR REPLACE TEMPORARY VIEW p AS VALUES (1, 1) AS
101 - 200 of 507 matches
Mail list logo
