[GitHub] spark issue #17153: [SPARK-19813] maxFilesPerTrigger combo latestFirst may m...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17153 **[Test build #73861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73861/testReport)** for PR 17153 at commit

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104266948 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16981 **[Test build #73876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73876/testReport)** for PR 16981 at commit

[GitHub] spark issue #17154: [SPARK-19084][sql] Ensure context class loader is set wh...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17154 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73865/ Test PASSed. ---

[GitHub] spark issue #17154: [SPARK-19084][sql] Ensure context class loader is set wh...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17154 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17154: [SPARK-19084][sql] Ensure context class loader is set wh...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17154 **[Test build #73865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73865/testReport)** for PR 17154 at commit

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16981 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16981 **[Test build #73875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73875/testReport)** for PR 16981 at commit

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16981 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73875/ Test FAILed. ---

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11601 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11601 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73868/ Test PASSed. ---

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11601 **[Test build #73868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73868/testReport)** for PR 11601 at commit

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104265487 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16981 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73874/ Test FAILed. ---

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16981 **[Test build #73874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73874/testReport)** for PR 16981 at commit

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16981 **[Test build #73875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73875/testReport)** for PR 16981 at commit

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16981 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17090: [Spark-19535][ML] RecommendForAllUsers RecommendForAllIt...

2017-03-03 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17090 LGTM Any other comments before we merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104264964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -288,6 +288,9 @@ case class Join(

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16981 **[Test build #73874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73874/testReport)** for PR 16981 at commit

[GitHub] spark issue #17155: [SPARK-19815][SQL] Not order able should be applied to r...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17155 **[Test build #73873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73873/testReport)** for PR 17155 at commit

[GitHub] spark pull request #17155: [SPARK-19815][SQL] Not order able should be appli...

2017-03-03 Thread zhzhan
GitHub user zhzhan opened a pull request: https://github.com/apache/spark/pull/17155 [SPARK-19815][SQL] Not order able should be applied to right key instead of left key ## What changes were proposed in this pull request? Change the orderable condition. ## How was this

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104264589 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala --- @@ -60,6 +60,12 @@ trait CatalystConf { * Enables CBO

[GitHub] spark issue #17043: [SPARK-19719][SS][WIP] Kafka writer for both structured ...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73870/ Test PASSed. ---

[GitHub] spark issue #17043: [SPARK-19719][SS][WIP] Kafka writer for both structured ...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17043 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17043: [SPARK-19719][SS][WIP] Kafka writer for both structured ...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17043 **[Test build #73870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73870/testReport)** for PR 17043 at commit

[GitHub] spark issue #17061: [SPARK-13446] [SQL] Support reading data from Hive 2.0.1...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17061 LGTM, pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17090: [Spark-19535][ML] RecommendForAllUsers RecommendForAllIt...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17090 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73866/ Test PASSed. ---

[GitHub] spark issue #17090: [Spark-19535][ML] RecommendForAllUsers RecommendForAllIt...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17090 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17061: [SPARK-13446] [SQL] Support reading data from Hive 2.0.1...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17061 **[Test build #73872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73872/testReport)** for PR 17061 at commit

[GitHub] spark issue #17090: [Spark-19535][ML] RecommendForAllUsers RecommendForAllIt...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17090 **[Test build #73866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73866/testReport)** for PR 17090 at commit

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104263617 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -217,6 +227,62 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104263580 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -217,6 +227,62 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104263454 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -217,6 +227,62 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104262508 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -597,6 +597,27 @@ private[spark] class

[GitHub] spark pull request #17061: [SPARK-13446] [SQL] Support reading data from Hiv...

2017-03-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17061#discussion_r104262397 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -98,7 +98,10 @@ class VersionsSuite extends QueryTest with

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104262277 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -169,16 +179,22 @@ private[hive] class

[GitHub] spark pull request #17061: [SPARK-13446] [SQL] Support reading data from Hiv...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17061#discussion_r104261953 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -98,7 +98,10 @@ class VersionsSuite extends QueryTest with

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104261785 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -565,7 +565,8 @@ private[spark] class

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259448 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -340,8 +342,8 @@ abstract class

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104261105 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -397,7 +398,8 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104261398 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1843,28 +1846,28 @@ class DDLSuite extends QueryTest

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259986 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala --- @@ -17,6 +17,7 @@ package org.apache.spark.sql.catalog

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259621 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -365,10 +367,10 @@ abstract class

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259668 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -508,7 +510,7 @@ abstract class

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104260144 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -397,7 +398,8 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259181 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -170,7 +170,7 @@ class SessionCatalog(

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259863 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -883,7 +885,7 @@ abstract class

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104260081 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -397,7 +398,8 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104259724 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -553,21 +555,21 @@ abstract class

[GitHub] spark pull request #15821: [SPARK-13534][PySpark] Using Apache Arrow to incr...

2017-03-03 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/15821#discussion_r104261004 --- Diff: pom.xml --- @@ -1871,6 +1872,25 @@ paranamer ${paranamer.version} + +

[GitHub] spark issue #17043: [SPARK-19719][SS][WIP] Kafka writer for both structured ...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17043 **[Test build #73870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73870/testReport)** for PR 17043 at commit

[GitHub] spark issue #15821: [SPARK-13534][PySpark] Using Apache Arrow to increase pe...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15821 **[Test build #73871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73871/testReport)** for PR 15821 at commit

[GitHub] spark issue #16782: [SPARK-19348][PYTHON] PySpark keyword_only decorator is ...

2017-03-03 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/16782 @jkbradley I think that last test comment is from an older test that just took a while to finish, Test build #73713 is from the last commit and passed, but I can rerun just in case if you like.

[GitHub] spark pull request #17061: [SPARK-13446] [SQL] Support reading data from Hiv...

2017-03-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17061#discussion_r104261002 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -98,7 +98,10 @@ class VersionsSuite extends QueryTest with

[GitHub] spark pull request #17061: [SPARK-13446] [SQL] Support reading data from Hiv...

2017-03-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17061#discussion_r104260866 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -98,7 +98,10 @@ class VersionsSuite extends QueryTest with

[GitHub] spark issue #17044: [SPARK-19718][SS]Handle more interrupt cases properly fo...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17044 **[Test build #73869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73869/testReport)** for PR 17044 at commit

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11601 **[Test build #73868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73868/testReport)** for PR 11601 at commit

[GitHub] spark issue #11601: [SPARK-13568] [ML] Create feature transformer to impute ...

2017-03-03 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/11601 Hi @MLnick I changed the surrogateDF format for better extensibility in the last update and added unit tests for multi-column support. Let me know if I miss anything. inputCol1|inputCol2

[GitHub] spark issue #17044: [SPARK-19718][SS]Handle more interrupt cases properly fo...

2017-03-03 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/17044 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2017-03-03 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r104258573 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #17044: [SPARK-19718][SS]Handle more interrupt cases prop...

2017-03-03 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/17044#discussion_r104258607 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -709,12 +717,13 @@ class StreamExecution(

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2017-03-03 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r104258382 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2017-03-03 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r104257956 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #16856: [SPARK-19516][DOC] update public doc to use Spark...

2017-03-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16856#discussion_r104255651 --- Diff: docs/quick-start.md --- @@ -10,12 +10,13 @@ description: Quick start tutorial for Spark SPARK_VERSION_SHORT This tutorial provides a quick

[GitHub] spark pull request #16856: [SPARK-19516][DOC] update public doc to use Spark...

2017-03-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16856#discussion_r104255799 --- Diff: docs/quick-start.md --- @@ -65,41 +66,41 @@ res3: Long = 15 ./bin/pyspark -Spark's primary abstraction is a distributed

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2017-03-03 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r104257857 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #16856: [SPARK-19516][DOC] update public doc to use Spark...

2017-03-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16856#discussion_r104255711 --- Diff: docs/quick-start.md --- @@ -29,28 +30,28 @@ or Python. Start it by running the following in the Spark directory: ./bin/spark-shell

[GitHub] spark pull request #16856: [SPARK-19516][DOC] update public doc to use Spark...

2017-03-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16856#discussion_r104256037 --- Diff: docs/quick-start.md --- @@ -137,37 +138,24 @@ res6: Array[(String, Int)] = Array((means,1), (under,2), (this,3), (Because,1), {%

[GitHub] spark pull request #11601: [SPARK-13568] [ML] Create feature transformer to ...

2017-03-03 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r104257741 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15666 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15666 **[Test build #73867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73867/testReport)** for PR 15666 at commit

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15666 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73867/ Test FAILed. ---

[GitHub] spark pull request #17043: [SPARK-19719][SS][WIP] Kafka writer for both stru...

2017-03-03 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/17043#discussion_r104257144 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15666 **[Test build #73867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73867/testReport)** for PR 15666 at commit

[GitHub] spark issue #17090: [Spark-19535][ML] RecommendForAllUsers RecommendForAllIt...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17090 **[Test build #73866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73866/testReport)** for PR 17090 at commit

[GitHub] spark issue #16856: [SPARK-19516][DOC] update public doc to use SparkSession...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16856 **[Test build #73864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73864/testReport)** for PR 16856 at commit

[GitHub] spark issue #16856: [SPARK-19516][DOC] update public doc to use SparkSession...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16856 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16856: [SPARK-19516][DOC] update public doc to use SparkSession...

2017-03-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16856 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73864/ Test PASSed. ---

[GitHub] spark issue #17154: [SPARK-19084][sql] Ensure context class loader is set wh...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17154 **[Test build #73865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73865/testReport)** for PR 17154 at commit

[GitHub] spark issue #17147: [Minor][Doc] Fix doc for web UI https configuration

2017-03-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17147 Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #17154: [SPARK-19084][sql] Ensure context class loader is...

2017-03-03 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/17154 [SPARK-19084][sql] Ensure context class loader is set when initializing Hive. A change in Hive 2.2 (most probably HIVE-13149) causes this code path to fail, since the call to

[GitHub] spark pull request #17147: [Minor][Doc] Fix doc for web UI https configurati...

2017-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16856: [SPARK-19516][DOC] update public doc to use SparkSession...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16856 **[Test build #73864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73864/testReport)** for PR 16856 at commit

[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...

2017-03-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17135 It's not just a matter of performance regression - it will brake any other code that has references to the file system being closed. -1. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-03-03 Thread budde
Github user budde commented on the issue: https://github.com/apache/spark/pull/16944 @cloud-fan Updated per your feedback. Mind taking a look at ```alterTableSchema()``` and checking that the change here is what you were looking for? --- If your project is set up for it, you can

[GitHub] spark issue #17053: [SPARK-18939][SQL] Timezone support in partition values.

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17053 **[Test build #73862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73862/testReport)** for PR 17053 at commit

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16944 **[Test build #73863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73863/testReport)** for PR 16944 at commit

[GitHub] spark issue #17091: DriverEndpoint#makeOffers race against CoarseGrainedSche...

2017-03-03 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17091 Can you add back the bug to the PR title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16929: [SPARK-19595][SQL] Support json array in from_jso...

2017-03-03 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16929#discussion_r104253528 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -480,23 +480,45 @@ case class

[GitHub] spark pull request #16929: [SPARK-19595][SQL] Support json array in from_jso...

2017-03-03 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16929#discussion_r104253484 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -480,23 +480,45 @@ case class

[GitHub] spark issue #17053: [SPARK-18939][SQL] Timezone support in partition values.

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17053 LGTM, pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17053: [SPARK-18939][SQL] Timezone support in partition values.

2017-03-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17053 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17149: [SPARK-19257][SQL]location for table/partition/database ...

2017-03-03 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/17149 cc @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17153: [SPARK-19813] maxFilesPerTrigger combo latestFirst may m...

2017-03-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17153 **[Test build #73861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73861/testReport)** for PR 17153 at commit

[GitHub] spark pull request #16929: [SPARK-19595][SQL] Support json array in from_jso...

2017-03-03 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/16929#discussion_r104253014 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -480,23 +480,45 @@ case class

[GitHub] spark pull request #16910: [SPARK-19575][SQL]Reading from or writing to a hi...

2017-03-03 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16910#discussion_r104252834 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1588,6 +1596,147 @@ class HiveDDLSuite }

[GitHub] spark pull request #17153: [SPARK-19813] maxFilesPerTrigger combo latestFirs...

2017-03-03 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/17153 [SPARK-19813] maxFilesPerTrigger combo latestFirst may miss old files in combination with maxFileAge in FileStreamSource ## What changes were proposed in this pull request? **The Problem**

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104252086 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -159,6 +165,10 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-03 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104251665 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -169,16 +179,22 @@ private[hive] class

<    1   2   3   4   5   6   7   >