[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75322/testReport)** for PR 17401 at commit

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17406 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75313/ Test PASSed. ---

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75313/testReport)** for PR 17406 at commit

[GitHub] spark issue #15192: [SPARK-14536] [SQL] fix to handle null value in array ty...

2017-03-28 Thread sureshthalamati
Github user sureshthalamati commented on the issue: https://github.com/apache/spark/pull/15192 sure. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75320/ Test PASSed. ---

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #75320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75320/testReport)** for PR 17170 at commit

[GitHub] spark issue #17458: [SPARK-20127][CORE] few warning have been fixed which In...

2017-03-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17458 They are suggestions in my point of view. it doesn't necessarily mean you should follow if there are some reasons. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #17442: [SPARK-20107][SQL] Speed up HadoopMapReduceCommitProtoco...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17442 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17442: [SPARK-20107][SQL] Speed up HadoopMapReduceCommitProtoco...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17442 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75321/ Test PASSed. ---

[GitHub] spark issue #17442: [SPARK-20107][SQL] Speed up HadoopMapReduceCommitProtoco...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17442 **[Test build #75321 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75321/testReport)** for PR 17442 at commit

[GitHub] spark pull request #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17457#discussion_r108475528 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala --- @@ -160,15 +140,36 @@ class SessionStateBuilder( * Session

[GitHub] spark issue #17442: [SPARK-20107][SQL] Speed up HadoopMapReduceCommitProtoco...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17442 **[Test build #75321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75321/testReport)** for PR 17442 at commit

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17208 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75312/ Test PASSed. ---

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17208 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17208 **[Test build #75312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75312/testReport)** for PR 17208 at commit

[GitHub] spark issue #17170: [SPARK-19825][R][ML] spark.ml R API for FPGrowth

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #75320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75320/testReport)** for PR 17170 at commit

[GitHub] spark issue #17400: [SPARK-19981][SQL] Update output partitioning info. in P...

2017-03-28 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17400 ISTM the solution you suggested does not work because the planner actually compares references (that is, `AttributeReferences` output by `child.outputPartioning`) instead of `Alias`. So, IMO we

[GitHub] spark issue #16985: [SPARK-19122][SQL] Unnecessary shuffle+sort added if joi...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16985 **[Test build #75319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75319/testReport)** for PR 16985 at commit

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to Indexed...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17459 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to ...

2017-03-28 Thread johnc1231
GitHub user johnc1231 opened a pull request: https://github.com/apache/spark/pull/17459 [SPARK-20109][MLlib] Added toBlockMatrixDense to IndexedRowMatrix ## What changes were proposed in this pull request? -I added the method `toBlockMatrixDense` to the IndexedRowMatrix

[GitHub] spark issue #17450: [SPARK-20121][SQL] simplify NullPropagation with NullInt...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17450 **[Test build #75318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75318/testReport)** for PR 17450 at commit

[GitHub] spark pull request #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17453: [SPARK-20124][SQL] Join reorder should keep the s...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-28 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17297 @sitalkedia This change is pretty contentious, there are lot of questions about whether or not this is a good change. I don't think discussing this here in github comments on a PR is the best form.

[GitHub] spark issue #17450: [SPARK-20121][SQL] simplify NullPropagation with NullInt...

2017-03-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17450 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17457 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-28 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108441341 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-28 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108450311 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-28 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108442588 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-28 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108449521 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-28 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108441411 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-28 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108442407 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17406 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17398: [SPARK-19716][SQL] support by-name resolution for struct...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17398 **[Test build #75317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75317/testReport)** for PR 17398 at commit

[GitHub] spark pull request #17398: [SPARK-19716][SQL] support by-name resolution for...

2017-03-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17398#discussion_r108448204 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -581,17 +592,24 @@ case class MapObjects

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17457 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75311/ Test PASSed. ---

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17457 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17457 **[Test build #75311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75311/testReport)** for PR 17457 at commit

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #75316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75316/testReport)** for PR 15009 at commit

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15009 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75314/ Test FAILed. ---

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #75314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75314/testReport)** for PR 15009 at commit

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #75314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75314/testReport)** for PR 15009 at commit

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13932 **[Test build #75315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75315/testReport)** for PR 13932 at commit

[GitHub] spark issue #13932: [SPARK-15354] [CORE] Topology aware block replication st...

2017-03-28 Thread shubhamchopra
Github user shubhamchopra commented on the issue: https://github.com/apache/spark/pull/13932 Rebased to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17406: [SPARK-20009][SQL] Use DDL strings for defining schema i...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17406 **[Test build #75313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75313/testReport)** for PR 17406 at commit

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-28 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108441033 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,76 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark pull request #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-03-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17435#discussion_r108437512 --- Diff: python/pyspark/sql/types.py --- @@ -57,7 +57,25 @@ def __ne__(self, other): @classmethod def typeName(cls): -

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17453 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17458: [SPARK-20127][CORE] few warning have been fixed which In...

2017-03-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17458 Probably, I guess this should be fine. Just in my experience, IntelliJ's inspection was quite okay except the case of breaking Scala 2.10. It might be better if they can be manually tested via

[GitHub] spark pull request #17406: [SPARK-20009][SQL] Use DDL strings for defining s...

2017-03-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17406#discussion_r108434080 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -169,30 +169,76 @@ class DataTypeSuite extends SparkFunSuite

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108433133 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -786,8 +786,8 @@ private[ui] object StagePage { info: TaskInfo,

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108432518 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagesTab.scala --- @@ -35,7 +35,7 @@ private[ui] class StagesTab(parent: SparkUI) extends

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17457 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17417: [SQL][DOC] Use recommended values for row boundaries in ...

2017-03-28 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17417 I'm going to merge the two PRs with your comments applied (i.e. excluding changes that are not necessarily doc-only). Thanks a lot for your time, Sean. Appreciate a lot. --- If your

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17453 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75310/ Test PASSed. ---

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17453 **[Test build #75310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75310/testReport)** for PR 17453 at commit

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17208 **[Test build #75312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75312/testReport)** for PR 17208 at commit

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2017-03-28 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17208 Looks like the tests were manually killed (-9). Thanks for catching that and fixing @liujianhuiouc --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2017-03-28 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17208 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread dbolshak
Github user dbolshak commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108421849 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -317,7 +317,7 @@ private[spark] object UIUtils extends Logging { def

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-28 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17297 btw I filed https://issues.apache.org/jira/browse/SPARK-20128 for the test timeout -- fwiw I don't think its a problem w/ the test but a potential real issue with the metrics system, though I don't

[GitHub] spark issue #17458: [SPARK-20127][CORE] few warning have been fixed which In...

2017-03-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17458 There're many changes related to UI part, actually we don't have many unit tests covered in this part, so I'm afraid these change may potentially introduce regression. --- If your project is

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108420602 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -317,7 +317,7 @@ private[spark] object UIUtils extends Logging { def

[GitHub] spark issue #17400: [SPARK-19981][SQL] Update output partitioning info. in P...

2017-03-28 Thread MasterDDT
Github user MasterDDT commented on the issue: https://github.com/apache/spark/pull/17400 Here is a sort example: ``` scala> val df1 = Seq((1, 2), (3, 4)).toDF("a", "b").sort("a") df1: org.apache.spark.sql.Dataset[org.apache.spark.sql.Row] = [a: int, b: int]

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108418582 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -317,7 +317,7 @@ private[spark] object UIUtils extends Logging { def

[GitHub] spark issue #17400: [SPARK-19981][SQL] Update output partitioning info. in P...

2017-03-28 Thread MasterDDT
Github user MasterDDT commented on the issue: https://github.com/apache/spark/pull/17400 For example here is a similar bug for sorting: >scala> Seq((1, 2), (3, 4)).toDF("a", "b").sort("a").selectExpr("a as newA", "b").sort("newA") res3:

[GitHub] spark issue #17400: [SPARK-19981][SQL] Update output partitioning info. in P...

2017-03-28 Thread MasterDDT
Github user MasterDDT commented on the issue: https://github.com/apache/spark/pull/17400 Just curious, how come the fix is not in this code?

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108414149 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -56,7 +56,7 @@ private[spark] class SparkUI private ( with Logging with

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108414360 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -513,8 +513,8 @@ private[spark] object UIUtils extends Logging { param

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108414748 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -290,7 +290,7 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17458#discussion_r108414675 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala --- @@ -31,7 +31,7 @@ private[ui] class JobsTab(parent: SparkUI) extends

[GitHub] spark issue #17458: [SPARK-20127][CORE] few warning have been fixed which In...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17458 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17458: [SPARK-20127][CORE] few warning have been fixed w...

2017-03-28 Thread dbolshak
GitHub user dbolshak opened a pull request: https://github.com/apache/spark/pull/17458 [SPARK-20127][CORE] few warning have been fixed which Intellij IDEA reported Intellij IDEA ## What changes were proposed in this pull request? Few changes related to Intellij IDEA inspection.

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75309/ Test PASSed. ---

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17428 **[Test build #75309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75309/testReport)** for PR 17428 at commit

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17457 **[Test build #75311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75311/testReport)** for PR 17457 at commit

[GitHub] spark pull request #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/17457 [SPARK-20126][SQL] Remove HiveSessionState ## What changes were proposed in this pull request? Commit https://github.com/apache/spark/commit/ea361165e1ddce4d8aa0242ae3e878d7b39f1de2 moved

[GitHub] spark issue #17457: [SPARK-20126][SQL] Remove HiveSessionState

2017-03-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17457 cc @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108407452 --- Diff: R/check-cran.sh --- @@ -20,14 +20,14 @@ set -o pipefail set -e -FWDIR="$(cd `dirname "${BASH_SOURCE[0]}"`; pwd)" -pushd

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17453 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17453 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75305/ Test FAILed. ---

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17453 **[Test build #75305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75305/testReport)** for PR 17453 at commit

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-28 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108400132 --- Diff: R/check-cran.sh --- @@ -20,14 +20,14 @@ set -o pipefail set -e -FWDIR="$(cd `dirname "${BASH_SOURCE[0]}"`; pwd)"

[GitHub] spark pull request #17428: [SPARK-20094][SQL] Preventing push down of IN sub...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17428 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17453: [SPARK-20124][SQL] Join reorder should keep the same ord...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17453 **[Test build #75310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75310/testReport)** for PR 17453 at commit

[GitHub] spark issue #17456: Branch 2.1

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17456 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17456: Branch 2.1

2017-03-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17456 @lnmohankumar please close this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17456: Branch 2.1

2017-03-28 Thread lnmohankumar
GitHub user lnmohankumar opened a pull request: https://github.com/apache/spark/pull/17456 Branch 2.1 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75308/ Test PASSed. ---

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17428: [SPARK-20094][SQL] Preventing push down of IN subquery t...

2017-03-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17428 **[Test build #75308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75308/testReport)** for PR 17428 at commit

[GitHub] spark pull request #17453: [SPARK-20124][SQL] Join reorder should keep the s...

2017-03-28 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17453#discussion_r108392855 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala --- @@ -127,7 +127,8 @@ abstract class PlanTest extends

[GitHub] spark pull request #17453: [SPARK-20124][SQL] Join reorder should keep the s...

2017-03-28 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17453#discussion_r108391785 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala --- @@ -127,7 +127,8 @@ abstract class PlanTest extends

[GitHub] spark pull request #17453: [SPARK-20124][SQL] Join reorder should keep the s...

2017-03-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17453#discussion_r108389791 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala --- @@ -127,7 +127,8 @@ abstract class PlanTest extends

<    1   2   3   4   >