[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19883#discussion_r155221911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -444,11 +444,11 @@ case class

[GitHub] spark pull request #19896: [SPARK-22693][SQL] InSet and CreateNamedStruct sh...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19896#discussion_r155222527 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -356,22 +356,25 @@ case class

[GitHub] spark pull request #19897: [SPARK-22694][SQL] Like and RLike should not use ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19897#discussion_r155222738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -119,33 +119,34 @@ case class Like(left:

[GitHub] spark issue #19854: [SPARK-22660][BUILD] Use position() and limit() to fix a...

Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19854 Please fix the title and also fulfill the PR description. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155223954 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -37,8 +37,10 @@ object InMemoryRelation {

[GitHub] spark pull request #19897: [SPARK-22694][SQL] Like and RLike should not use ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19897#discussion_r155224228 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -119,33 +119,34 @@ case class Like(left:

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19905 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/19883 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

Github user srowen commented on the issue: https://github.com/apache/spark/pull/19893 Do any of those leaked threads look like they might be real issues to fix? you could paste the results here, minus anything you know isn't a problem. ---

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet should not use global variables

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19896 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19901: [SPARK-22705][SQL] Case, Coalesce, and In use les...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19901#discussion_r155231783 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -237,37 +237,39 @@ case class In(value: Expression,

[GitHub] spark issue #19910: [SPARK-22715][SQL] Reuse the same array in CreateNamedSt...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19910 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19910: [SPARK-22715][SQL] Reuse the same array in CreateNamedSt...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19910 **[Test build #84554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84554/testReport)** for PR 19910 at commit

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19900 **[Test build #84555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84555/testReport)** for PR 19900 at commit

[GitHub] spark pull request #19900: [SPARK-22695][SQL] ScalaUDF should not use global...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19900#discussion_r155237198 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -982,35 +982,29 @@ case class ScalaUDF(

[GitHub] spark pull request #19900: [SPARK-22695][SQL] ScalaUDF should not use global...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19900#discussion_r155238140 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -982,35 +982,29 @@ case class ScalaUDF(

[GitHub] spark pull request #19896: [SPARK-22693][SQL] InSet and CreateNamedStruct sh...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19896#discussion_r155217583 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -356,22 +356,25 @@ case class

[GitHub] spark pull request #19900: [SPARK-22695][SQL] ScalaUDF should not use global...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19900#discussion_r155218848 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -982,35 +982,30 @@ case class ScalaUDF(

[GitHub] spark pull request #19900: [SPARK-22695][SQL] ScalaUDF should not use global...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19900#discussion_r155219578 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -982,35 +982,30 @@ case class ScalaUDF(

[GitHub] spark pull request #19897: [SPARK-22694][SQL] Like and RLike should not use ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19897#discussion_r155222416 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -119,33 +119,34 @@ case class Like(left:

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19885 >User info isn't picked up from the URL, it's taken off your Kerberos credentials. If you are running HDFS unkerberized, then UGI takes it from the environment variable HADOOP_USER_NAME.

[GitHub] spark pull request #19883: [SPARK-22684][SQL] datetime functions should not ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19883#discussion_r155222959 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -444,11 +444,11 @@ case class

[GitHub] spark pull request #19897: [SPARK-22694][SQL] Like and RLike should not use ...

Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/19897 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155223876 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -37,8 +37,10 @@ object InMemoryRelation {

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155223822 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -71,9 +74,8 @@ case class InMemoryRelation(

[GitHub] spark pull request #19897: [SPARK-22694][SQL] Like and RLike should not use ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19897#discussion_r155223697 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -119,33 +119,34 @@ case class Like(left:

[GitHub] spark pull request #19896: [SPARK-22693][SQL] InSet and CreateNamedStruct sh...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19896#discussion_r155224703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -356,22 +356,25 @@ case class

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155225855 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,22 @@ public DataSourceV2Options(Map

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet and CreateNamedStruct should no...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84546/ Test PASSed. ---

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet and CreateNamedStruct should no...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19896 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19896: [SPARK-22693][SQL] InSet and CreateNamedStruct sh...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19896#discussion_r155226100 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -356,22 +356,25 @@ case class

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19899 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84547/ Test PASSed. ---

[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19908 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84548/ Test PASSed. ---

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19890 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84545/ Test PASSed. ---

[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19908 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet should not use global variables

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19896 **[Test build #84552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84552/testReport)** for PR 19896 at commit

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19890 **[Test build #84545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84545/testReport)** for PR 19890 at commit

[GitHub] spark pull request #19836: [SPARK-22618][CORE] Catch exception in removeRDD ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19836#discussion_r155230290 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -159,11 +160,18 @@ class BlockManagerMasterEndpoint(

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19836 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

Github user srowen commented on the issue: https://github.com/apache/spark/pull/19890 It would only cause a problem if somehow and older Janino was on the classpath, which does not have the new exception type. I don't think there's a reason to believe that happens in practice (i.e.

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231264 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231340 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231523 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231606 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231547 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155231792 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155232397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155233875 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155233734 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -114,4 +114,171 @@ object

[GitHub] spark pull request #19901: [SPARK-22705][SQL] Case, Coalesce, and In use les...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19901#discussion_r155234845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -237,37 +237,39 @@ case class In(value:

[GitHub] spark pull request #19910: [SPARK-22715][SQL] Reuse the same array in Create...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19910#discussion_r155238576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -356,25 +356,24 @@ case class

[GitHub] spark pull request #19900: [SPARK-22695][SQL] ScalaUDF should not use global...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19900#discussion_r155239094 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -982,35 +982,29 @@ case class ScalaUDF(

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19899 **[Test build #84556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84556/testReport)** for PR 19899 at commit

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19899 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84556/ Test FAILed. ---

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389433 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389404 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389363 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389138 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,22 @@ public DataSourceV2Options(Map

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19902 LGTM except three comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19810: [SPARK-22599][SQL] In-Memory Table Pruning withou...

Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/19810#discussion_r155392065 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -193,38 +195,68 @@ case class

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19882 It's rebased to the master to resolve conflicts. Also, I addressed the comments. Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155393714 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -20,10 +20,12 @@ package org.apache.spark // scalastyle:off import

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

Github user bolkedebruin commented on the issue: https://github.com/apache/spark/pull/19911 Haha sure :-). Or maybe @danielvdende if he is still following --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155394195 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155395310 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark issue #19915: [SPARK-22721] BytesToBytesMap peak memory usage not accu...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84572/ Test PASSed. ---

[GitHub] spark issue #19915: [SPARK-22721] BytesToBytesMap peak memory usage not accu...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19915 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19901 **[Test build #84584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84584/testReport)** for PR 19901 at commit

[GitHub] spark pull request #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convert...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19499#discussion_r155397898 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -106,7 +106,7 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

Github user brad-kaiser commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r155399170 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -601,40 +602,41 @@ class

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/19890 I'd LGTM on both upgrading to Janino 3.0.8 and also changing the exception type captured from `JaninoRuntimeException` to the new `InternalCompilerException`. It's never a good idea to have

[GitHub] spark pull request #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convert...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19499#discussion_r155399904 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -106,7 +106,7 @@ private[spark] object HiveUtils extends Logging {

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19041 **[Test build #84585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84585/testReport)** for PR 19041 at commit

[GitHub] spark pull request #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0....

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19890 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19621: [SPARK-11215][ML] Add multiple columns support to String...

Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19621 @felixcheung Yes, the spark.mlp test result changed because of indexer order changed. That's because, StringIndexer when item frequency equal, there's no definite rule for index order. And, in

[GitHub] spark issue #19783: [SPARK-21322][SQL] support histogram in filter cardinali...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19783 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19901: [SPARK-22705][SQL] Case, Coalesce, and In use les...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19901#discussion_r155403171 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -180,13 +180,18 @@ case class CaseWhen(

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19222 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84579/testReport)** for PR 19902 at commit

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155390570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

Github user bolkedebruin commented on the issue: https://github.com/apache/spark/pull/19911 Maybe we are :-). Ok going to your side of the discussion, why not issue `TRUNCATE ONLY` by default with Postgres? This does not have 'side effects' and will always do the right thing? ---

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155390445 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #84580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84580/testReport)** for PR 19893 at commit

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155391390 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -225,57 +162,39 @@ abstract class

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155392637 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala --- @@ -15,20 +15,51 @@ * limitations under the

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19911 +1 for the idea. Could you make a PR for that? We can discuss on that. Without side effects, why not? :) --- - To

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/19810 @cloud-fan for this case, if the data has been dumped to disk or some non-local tasks are started, I/O is involved in addition to the overhead to start extra tasks. If all data is in-memory, only

[GitHub] spark issue #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19882 **[Test build #84581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84581/testReport)** for PR 19882 at commit

[GitHub] spark pull request #19882: [SPARK-22672][SQL][TEST] Refactor ORC Tests

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19882#discussion_r155394617 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -614,27 +523,88 @@ class OrcQuerySuite

[GitHub] spark issue #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetasto...

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19499 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 great! Thanks @gatorsmile for your comments. I have updated with code comments, please take a look. Thanks. ---

[GitHub] spark issue #19915: [SPARK-22721] BytesToBytesMap peak memory usage not accu...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19915 **[Test build #84572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84572/testReport)** for PR 19915 at commit

[GitHub] spark issue #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetasto...

Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19499 Since we starts to use new `native`OrcFileFormat by default, I'm retriggering this. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetasto...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19499 **[Test build #84583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84583/testReport)** for PR 19499 at commit

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84582/testReport)** for PR 19902 at commit

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19890 cc @hvanhovell @cloud-fan @rednaxelafx --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convert...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19499#discussion_r155398624 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -106,7 +106,7 @@ private[spark] object HiveUtils extends Logging {

<    1   2   3   4   5   6   7   >