[GitHub] spark issue #20727: [SPARK-23577][SQL] Supports custom line separator for te...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20727 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1639/

[GitHub] spark issue #20727: [SPARK-23577][SQL] Supports custom line separator for te...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20727 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20727: [SPARK-23577][SQL] Supports custom line separator for te...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20727 **[Test build #88415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88415/testReport)** for PR 20727 at commit

[GitHub] spark pull request #20811: [SPARK-23668][K8S] Add config option for passing ...

2018-03-20 Thread andrusha
Github user andrusha commented on a diff in the pull request: https://github.com/apache/spark/pull/20811#discussion_r175710242 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala --- @@ -108,6 +109,8 @@

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1640/

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1623/ ---

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20851: [SPARK-23727][SQL] Support for pushing down filte...

2018-03-20 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/20851#discussion_r175684322 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -313,6 +316,36 @@ class

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20861 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20864: [SPARK-23745][SQL]Remove the directories of the �...

2018-03-20 Thread zuotingbing
GitHub user zuotingbing opened a pull request: https://github.com/apache/spark/pull/20864 [SPARK-23745][SQL]Remove the directories of the “hive.downloaded.resources.dir” when HiveThriftServer2 stopped ## What changes were proposed in this pull request?

[GitHub] spark issue #20864: [SPARK-23745][SQL]Remove the directories of the “hive....

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20864 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20327 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88409/ Test FAILed. ---

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88412/ Test FAILed. ---

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-03-20 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r175727668 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -145,4 +159,15 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-03-20 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r175696187 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -172,17 +174,23 @@ object ExtractFiltersAndInnerJoins

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-03-20 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r175725372 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,49 @@ object ReorderJoin extends

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-03-20 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r175696570 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -141,14 +141,16 @@ object ExtractEquiJoinKeys extends

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-03-20 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r175696302 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -172,17 +174,23 @@ object ExtractFiltersAndInnerJoins

[GitHub] spark pull request #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uui...

2018-03-20 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20861#discussion_r175727781 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolvedUuidExpressionsSuite.scala --- @@ -0,0 +1,79 @@ +/* + *

[GitHub] spark pull request #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uui...

2018-03-20 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20861#discussion_r175727739 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolvedUuidExpressionsSuite.scala --- @@ -0,0 +1,79 @@ +/* + *

[GitHub] spark issue #20865: [SPARK-23542] The exists action shoule be further optimi...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20865 **[Test build #88417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88417/testReport)** for PR 20865 at commit

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1638/

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20861 **[Test build #88414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88414/testReport)** for PR 20861 at commit

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-20 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/20858 @maropu What other libraries do you mean? I'm not aware of any library providing this functionality on top Spark SQL. When using Spark SQL as an ETL tool for structured and nested data,

[GitHub] spark pull request #20865: [SPARK-23542] The exists action shoule be further...

2018-03-20 Thread KaiXinXiaoLei
GitHub user KaiXinXiaoLei opened a pull request: https://github.com/apache/spark/pull/20865 [SPARK-23542] The exists action shoule be further optimized in logical plan ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) The

[GitHub] spark pull request #20803: [SPARK-23653][SQL] Show sql statement in spark SQ...

2018-03-20 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/20803#discussion_r175683700 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -166,20 +168,28 @@ private[sql] object Dataset { class Dataset[T]

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1641/

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19108 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19108 **[Test build #88416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88416/testReport)** for PR 19108 at commit

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20774 **[Test build #88412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88412/testReport)** for PR 20774 at commit

[GitHub] spark pull request #20847: [SPARK-23644][CORE][UI][BACKPORT-2.3] Use absolut...

2018-03-20 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/20847 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20862: [SPARK-23744][CORE]Fix memory leak in ReadableChannelFil...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20862 **[Test build #88410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88410/testReport)** for PR 20862 at commit

[GitHub] spark issue #20850: [SPARK-23713][SQL] Cleanup UnsafeWriter and BufferHolder...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20850 **[Test build #88411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88411/testReport)** for PR 20850 at commit

[GitHub] spark issue #20865: [SPARK-23542] The exists action shoule be further optimi...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20865 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20865: [SPARK-23542] The exists action shoule be further optimi...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20865 **[Test build #88418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88418/testReport)** for PR 20865 at commit

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88420/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-03-20 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/20640 @squito @IgorBerman let's move on with this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20861 **[Test build #88422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88422/testReport)** for PR 20861 at commit

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1644/

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88423/testReport)** for PR 20787 at commit

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20861 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88419/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88419/ Test FAILed. ---

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88421/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88421/ Test FAILed. ---

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88420/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88420/ Test FAILed. ---

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88421/testReport)** for PR 20787 at commit

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-20 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20861 @hvanhovell Thanks! Your comments are addressed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20796: [SPARK-23649][SQL] Skipping chars disallowed in UTF-8

2018-03-20 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20796 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20865: [SPARK-23542] The exists action shoule be further optimi...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20865 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88418/ Test FAILed. ---

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88419/testReport)** for PR 20787 at commit

[GitHub] spark pull request #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler ...

2018-03-20 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/20641#discussion_r175804550 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala --- @@ -199,6 +199,38 @@ class

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-03-20 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/20579 @gatorsmile When you get a chance, could you please see if the check for internal datasource looks reasonable ? --- - To

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #88423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88423/testReport)** for PR 20787 at commit

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20787: Documenting months_between direction

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88423/ Test PASSed. ---

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r175880756 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java --- @@ -49,55 +51,81 @@ public static int hashInt(int input, int

[GitHub] spark pull request #20827: [SPARK-23666][SQL] Do not display exprIds of Alia...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20827#discussion_r175881422 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala --- @@ -304,4 +304,14 @@ class UDFSuite extends QueryTest with SharedSQLContext {

[GitHub] spark pull request #20827: [SPARK-23666][SQL] Do not display exprIds of Alia...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20827#discussion_r175881819 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -288,6 +288,7 @@ trait NonSQLExpression extends

[GitHub] spark issue #20827: [SPARK-23666][SQL] Do not display exprIds of Alias in us...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20827 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20774 Retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20726: [SPARK-23574][SQL] Report SinglePartition in DataSourceV...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20726 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20774 **[Test build #88433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88433/testReport)** for PR 20774 at commit

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1649/

[GitHub] spark pull request #20726: [SPARK-23574][SQL] Report SinglePartition in Data...

2018-03-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20726 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20844: [SPARK-23707][SQL] Fresh 'initRange' name to avoi...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20844#discussion_r175884882 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -396,9 +396,11 @@ case class RangeExec(range:

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-20 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r175885446 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java --- @@ -49,55 +51,81 @@ public static int hashInt(int input, int seed)

[GitHub] spark pull request #20803: [SPARK-23653][SQL] Show sql statement in spark SQ...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20803#discussion_r175885690 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -166,20 +168,28 @@ private[sql] object Dataset { class Dataset[T]

[GitHub] spark issue #20687: [SPARK-23500][SQL] Fix complex type simplification rules...

2018-03-20 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20687 Will submit a separate PR for tests only. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20774 **[Test build #88433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88433/testReport)** for PR 20774 at commit

[GitHub] spark pull request #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange w...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20831#discussion_r175951487 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -68,6 +69,15 @@ case class InMemoryRelation(

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88431/ Test FAILed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20866: [SPARK-23749][SQL] Avoid Hive.get() to compatible with d...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20866 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88428/ Test PASSed. ---

[GitHub] spark issue #20866: [SPARK-23749][SQL] Avoid Hive.get() to compatible with d...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20866 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20798: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-20 Thread mstewart141
Github user mstewart141 commented on the issue: https://github.com/apache/spark/pull/20798 all that makes sense; i will update. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20859: [SPARK-23702][SS] Forbid watermarks on both sides of sta...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20859 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88432/ Test PASSed. ---

[GitHub] spark issue #20859: [SPARK-23702][SS] Forbid watermarks on both sides of sta...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20859 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-03-20 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/20579 @cloud-fan Thank you. I assumed (wrongly) that we don't want to change the behaviour for an external file based datasource and we wanted to scope our check only to spark built in data sources.

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20579 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20579 **[Test build #88436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88436/testReport)** for PR 20579 at commit

[GitHub] spark issue #20579: [SPARK-23372][SQL] Writing empty struct in parquet fails...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20579 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1652/

[GitHub] spark pull request #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange w...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20831#discussion_r175951728 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -169,7 +174,10 @@ case class

[GitHub] spark issue #20851: [SPARK-23727][SQL] Support for pushing down filters for ...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88426/ Test PASSed. ---

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20657 **[Test build #88427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88427/testReport)** for PR 20657 at commit

[GitHub] spark issue #20853: [SPARK-23729][CORE] Respect URI fragment when resolving ...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20853 **[Test build #88430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88430/testReport)** for PR 20853 at commit

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-20 Thread huaxingao
Github user huaxingao commented on the issue: https://github.com/apache/spark/pull/20777 @BryanCutler Do you mind if I close this PR and open a new one? I got problems when I tried to resolve the conflicts. --- -

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-20 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r175938595 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -126,7 +126,11 @@ private[spark] abstract class WebUI( def bind(): Unit = {

[GitHub] spark issue #20867: Spark 23759

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20867 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange when cac...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20831 good catch! LGTM except a few comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20786: [SPARK-14681][ML] Provide label/impurity stats fo...

2018-03-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20786#discussion_r175955065 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala --- @@ -84,35 +86,73 @@ private[ml] object Node { /** * Create a new

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20657 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88427/ Test PASSed. ---

[GitHub] spark issue #20866: [SPARK-23749][SQL] Avoid Hive.get() to compatible with d...

2018-03-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20866 **[Test build #88428 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88428/testReport)** for PR 20866 at commit

[GitHub] spark pull request #20579: [SPARK-23372][SQL] Writing empty struct in parque...

2018-03-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20579#discussion_r175950101 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -77,7 +77,6 @@ class

<    1   2   3   4   5   >