Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21121
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21121
**[Test build #89686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89686/testReport)**
for PR 21121 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21121
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89686/
Test FAILed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20959#discussion_r183226807
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -882,6 +882,9 @@ def csv(self, path, mode=None, compression=None,
sep=None, quote=None, escape=No
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21052
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21031
@kiszk Could you also update the PR description? LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21052
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
I think we are almost there - sorry for late response.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21107
@BryanCutler, I checked this but looks still printing out duplicated logs
.. however, I think in this way I could deal with
https://github.com/apache/spark/pull/21107#issuecomment-382914524.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2564/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21107
Will remove WIP after few more checking in my local and Jenkins's output.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89687/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21107
**[Test build #89688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89688/testReport)**
for PR 21107 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89688/
Test PASSed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183227276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -175,11 +187,15 @@ object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183227330
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183227312
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextOptions.scala
---
@@ -41,19 +41,25 @@ private[text] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21121
**[Test build #89686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89686/testReport)**
for PR 21121 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21107
**[Test build #89687 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89687/testReport)**
for PR 21107 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21107#discussion_r183230073
--- Diff: python/pyspark/ml/tests.py ---
@@ -2136,17 +2136,23 @@ class ImageReaderTest2(PySparkTestCase):
@classmethod
def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21107#discussion_r183230184
--- Diff: python/run-tests.py ---
@@ -109,8 +111,34 @@ def run_individual_python_test(test_name,
pyspark_python):
# this code is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21107
**[Test build #89688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89688/testReport)**
for PR 21107 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2565/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21107
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21107
**[Test build #89687 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89687/testReport)**
for PR 21107 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21056#discussion_r183227100
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2128,38 +2128,77 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21056#discussion_r183227071
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2128,38 +2128,77 @@ class JsonSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20940
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89685/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20940
**[Test build #89685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89685/testReport)**
for PR 20940 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20940
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20933
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/20933
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21031
Sure, done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20933
**[Test build #89690 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89690/testReport)**
for PR 20933 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20933
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2567/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21123
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21123
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89689/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21123
**[Test build #89689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89689/testReport)**
for PR 21123 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21056
**[Test build #89692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89692/testReport)**
for PR 21056 at commit
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21121#discussion_r183253723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -883,3 +884,140 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89691/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20933
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89690/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89691/testReport)**
for PR 20937 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21082
**[Test build #89693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89693/testReport)**
for PR 21082 at commit
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21121#discussion_r183253226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -883,3 +884,140 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21082
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2568/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21082
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user edwinalu commented on the issue:
https://github.com/apache/spark/pull/20940
Could a committer please request a retest? It looks like the tests passed
(https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89685/testReport/),
and the failure occurs after
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21071
@devaraj-kavali can you close this PR first?
Looks like there isn't any reason to really use htrace anymore ...
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #89691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89691/testReport)**
for PR 20937 at commit
Github user devaraj-kavali closed the pull request at:
https://github.com/apache/spark/pull/21071
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21056
**[Test build #89692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89692/testReport)**
for PR 21056 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21056
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89692/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21056
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183258353
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183253488
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r18325
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183257799
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2569/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21082
**[Test build #89693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89693/testReport)**
for PR 21082 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21125
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21125
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2#discussion_r183266741
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuery.scala
---
@@ -114,11 +119,8 @@ case class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21117
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183270654
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -237,6 +237,9 @@ def json(self, path, schema=None,
primitivesAsString=None, prefersDecimal=None,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183270773
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -773,6 +776,8 @@ def json(self, path, mode=None, compression=None,
dateFormat=None, timestampForm
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21124
**[Test build #89694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89694/testReport)**
for PR 21124 at commit
Github user tedyu commented on the issue:
https://github.com/apache/spark/pull/21124
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21117
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183268807
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -55,56 +42,38 @@ object InMemoryRelation {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183269227
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r183269033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r183270323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20980
**[Test build #89698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89698/testReport)**
for PR 20980 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21125
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21125
Jenkins, please test this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14083#discussion_r183265525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -138,6 +140,88 @@ package object expressions {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14083
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21100
**[Test build #89696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89696/testReport)**
for PR 21100 at commit
Github user liutang123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21100#discussion_r183269702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -171,6 +171,15 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21072#discussion_r183272597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -736,12 +736,22 @@ object EliminateSorts extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89694/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20980
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2571/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20980
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21125
**[Test build #89699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89699/testReport)**
for PR 21125 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89701/testReport)**
for PR 21083 at commit
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21124
@brkyvz PTAL.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/2
**[Test build #89695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89695/testReport)**
for PR 2 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183269323
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20937
LGTM except a few minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -213,6 +215,25 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -89,8 +91,13 @@ case class DataSource(
1 - 100 of 147 matches
Mail list logo
