Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21537
**[Test build #93108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93108/testReport)**
for PR 21537 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #93107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93107/testReport)**
for PR 21599 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21784
**[Test build #93111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93111/testReport)**
for PR 21784 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21514
**[Test build #93104 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93104/testReport)**
for PR 21514 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93106 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93106/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21782
**[Test build #93105 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93105/testReport)**
for PR 21782 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21357
**[Test build #93109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93109/testReport)**
for PR 21357 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21772
**[Test build #93112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93112/testReport)**
for PR 21772 at commit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21514#discussion_r202675020
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -130,7 +130,12 @@ private[deploy] class Master(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21537
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202676603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21784
**[Test build #93111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93111/testReport)**
for PR 21784 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21784
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21784
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93111/
Test PASSed.
---
Github user DylanGuedes commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202683445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202686626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user mgaido91 closed the pull request at:
https://github.com/apache/spark/pull/18329
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user DylanGuedes commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202688999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202689850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202691583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202692276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21045#discussion_r202693252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -128,6 +128,172 @@ case class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202708012
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21740
Merged to master. Your JIRA handle is "shahid" right?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21785
**[Test build #93114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93114/testReport)**
for PR 21785 at commit
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21785
[SPARK-24529][BUILD][FOLLOW-UP] Set spotbugs-maven-plugin's fork to true
## What changes were proposed in this pull request?
Set `spotbugs-maven-plugin`'s fork to `true`, otherwise will
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/21779
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/21740
Thanks @srowen. yes, my JIRA handle is "shahid".
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21740
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21468#discussion_r202713900
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -813,8 +813,14 @@ private[spark] class Client(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21785
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21785
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21765
**[Test build #4215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4215/testReport)**
for PR 21765 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21537#discussion_r202718372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -740,31 +739,37 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21537#discussion_r202597179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -196,7 +221,7 @@ object Block {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21537#discussion_r202718932
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -825,43 +832,43 @@ case class Cast(child: Expression,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21704
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21352
**[Test build #93115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93115/testReport)**
for PR 21352 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21352#discussion_r202723448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -741,14 +735,15 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21704
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21352
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21352#discussion_r202725239
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3226,7 +3218,7 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202725810
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202727503
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #93107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93107/testReport)**
for PR 21599 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93107/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21352
**[Test build #93116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93116/testReport)**
for PR 21352 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21537
**[Test build #93108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93108/testReport)**
for PR 21537 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21537
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21537
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93108/
Test FAILed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21537
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21537
**[Test build #93117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93117/testReport)**
for PR 21537 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21635
+1 . @jerryshao
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21656
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21537
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21638#discussion_r202737100
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -47,7 +47,7 @@ private[spark] abstract class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202738657
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r202738910
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21729
@hthuynh2 please update based on the comments above. You can leave the
type as Hashset and fix the other typos, identations, and comments.
---
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r202851707
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r202857071
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r202857737
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -434,6 +434,17 @@ private[spark] class MapOutputTrackerMaster(
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21710
**[Test build #93145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93145/testReport)**
for PR 21710 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202867741
--- Diff: python/pyspark/sql/tests.py ---
@@ -5060,6 +5049,144 @@ def test_type_annotation(self):
df =
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202861461
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -94,36 +95,59 @@ object
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202863732
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -97,6 +103,64 @@ class
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202863696
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -97,6 +103,64 @@ class
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202865865
--- Diff: python/pyspark/sql/tests.py ---
@@ -5471,6 +5598,22 @@ def foo(_):
self.assertEqual(r.a, 'hi')
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202865230
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -23,21 +23,27 @@ import
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202864194
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -97,6 +103,64 @@ class
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202865674
--- Diff: python/pyspark/sql/tests.py ---
@@ -5471,6 +5598,22 @@ def foo(_):
self.assertEqual(r.a, 'hi')
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202863084
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -167,7 +191,8 @@ object ExtractPythonUDFs
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202863906
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -97,6 +103,64 @@ class
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202864128
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -97,6 +103,64 @@ class
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202863867
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -97,6 +103,64 @@ class
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202861241
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -94,36 +95,59 @@ object
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r202864609
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
---
@@ -23,21 +23,27 @@ import
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21780
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20425
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19492
I am actually still hesitant. FWIW, there's another PR for this if I am not
mistaken - `https://github.com/apache/spark/pull/21439`. I don't quite like
that approach too but at least that has
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21442
This hasn't get any test pass even once. The test is broken by this commit:
Before:
```
$ build/sbt "~sql/test-only *SQLQueryTestSuite -- -z
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21785
cc @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21787
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21787
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
601 - 692 of 692 matches
Mail list logo
